Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4991)

Unified Diff: chrome/browser/chromeos/gdata/gdata_util_unittest.cc

Issue 10914173: Wrap ChromeOS specific functions with OS_CHROMEOS macro (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_util_unittest.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_util_unittest.cc b/chrome/browser/chromeos/gdata/gdata_util_unittest.cc
index 2fbbf6fb22d4c295efc187f4d3debc4cb97c2060..9bc4e83132d2ff65b16725c5b391453521922208 100644
--- a/chrome/browser/chromeos/gdata/gdata_util_unittest.cc
+++ b/chrome/browser/chromeos/gdata/gdata_util_unittest.cc
@@ -7,9 +7,12 @@
#include "base/i18n/time_formatting.h"
#include "base/time.h"
#include "base/utf_string_conversions.h"
-#include "chrome/browser/chromeos/system/timezone_settings.h"
#include "testing/gtest/include/gtest/gtest.h"
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/system/timezone_settings.h"
+#endif // OS_CHROMEOS
+
namespace gdata {
namespace util {
namespace {
@@ -20,6 +23,9 @@ std::string FormatTime(const base::Time& time) {
} // namespace
+// TODO(yoshiki): Find platform independent way to get/set local timezone.
+// (http://crbug.com/147524).
+#if defined(OS_CHROMEOS)
TEST(GDataUtilTest, GetTimeFromStringLocalTimezone) {
// Creates time object GMT.
base::Time::Exploded exploded = {2012, 7, 0, 14, 1, 3, 21, 151};
@@ -85,6 +91,7 @@ TEST(GDataUtilTest, GetTimeFromString) {
EXPECT_EQ(FormatTime(base::Time::FromUTCExploded(target_time3)),
FormatTime(test_time));
}
+#endif // OS_CHROMEOS
TEST(GDataUtilTest, FormatTimeAsString) {
base::Time::Exploded exploded_time = {2012, 7, 0, 19, 15, 59, 13, 123};
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698