Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 10914173: Wrap ChromeOS specific functions with OS_CHROMEOS macro (Closed)

Created:
8 years, 3 months ago by nhiroki
Modified:
8 years, 3 months ago
Reviewers:
yoshiki, kochi
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, satorux1, kinuko
Visibility:
Public.

Description

Wrap ChromeOS specific functions with OS_CHROMEOS macro This patch is separated from http://codereview.chromium.org/10920091/ BUG=127855 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155690

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M chrome/browser/chromeos/gdata/gdata_util.cc View 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_util_unittest.cc View 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
nhiroki
Hi, kochi-san and yoshiki-san Can you review this? Thanks!
8 years, 3 months ago (2012-09-10 07:08:07 UTC) #1
yoshiki
LGTM
8 years, 3 months ago (2012-09-10 07:13:36 UTC) #2
yoshiki
Some of other files still include chromeos-specific headers. For example, - chrome/browser/google_apis/drive_api_operations.h - chrome/browser/google_apis/auth_service.cc - ...
8 years, 3 months ago (2012-09-10 07:18:51 UTC) #3
kochi
Yoshiki, is this comment for http://codereview.chromium.org/10920091/ ? On 2012/09/10 07:18:51, yoshiki wrote: > Some of ...
8 years, 3 months ago (2012-09-10 07:29:43 UTC) #4
yoshiki
Thanks, kochi-san. I added (almost) same comment as http://codereview.chromium.org/10920091/#msg31/. On 2012/09/10 07:29:43, Takayoshi Kochi wrote: ...
8 years, 3 months ago (2012-09-10 07:36:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/10914173/1
8 years, 3 months ago (2012-09-10 07:41:33 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 09:27:34 UTC) #7
Change committed as 155690

Powered by Google App Engine
This is Rietveld 408576698