Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10914053: Relocating files in the nacl repo that belong in chrome. (Closed)

Created:
8 years, 3 months ago by bradn
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Relocating files in the nacl repo that belong in chrome. Moving src/native_client/chrome_root.scons to src/ppapi/native_client/chrome_main.scons (no diff) Moving tests and components listed therein. Moving browser_tester. Files are unmodified except for small pathing adjustments to irt_stub.gyp and browser_tester.py to make them function in their new location, copyright header changes and one >80 line wrap. Groundwork is laid to have a chrome side copy step in gyp be responsible for populating a few ppapi side headers. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2957 TEST=None R=ncbray@chromium.org,noeallen@chromium.org,brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155572

Patch Set 1 : initial #

Patch Set 2 : fix headers #

Patch Set 3 : merge and fix windows #

Total comments: 10

Patch Set 4 : review comments + merge #

Patch Set 5 : fix #

Total comments: 2

Patch Set 6 : merge #

Patch Set 7 : merge #

Patch Set 8 : fix #

Patch Set 9 : tweak windows #

Total comments: 1

Patch Set 10 : merge and drop non-commit stuff #

Patch Set 11 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7944 lines, -9 lines) Patch
M ppapi/native_client/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A ppapi/native_client/chrome_main.scons View 1 2 3 1 chunk +664 lines, -0 lines 0 comments Download
M ppapi/native_client/native_client.gyp View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
A ppapi/native_client/src/include/nacl_memory.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
A ppapi/native_client/src/trusted/weak_ref/call_on_main_thread.h View 1 1 chunk +252 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp View 1 chunk +29 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/irt_stub/libppapi.a View 1 1 chunk +14 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/irt_stub/libppapi.so View 1 1 chunk +17 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/irt_stub/nacl.scons View 1 1 chunk +23 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/irt_stub/plugin_main_irt.c View 1 1 chunk +16 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/irt_stub/ppapi_plugin_main.c View 1 1 chunk +24 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/irt_stub/ppapi_plugin_start.c View 1 1 chunk +70 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/irt_stub/ppapi_start.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/irt_stub/thread_creator.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/irt_stub/thread_creator.c View 1 1 chunk +51 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/nacl_ppapi_util/nacl.scons View 1 1 chunk +12 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/nacl_ppapi_util/nacl_ppapi_util.h View 1 1 chunk +202 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/nacl_ppapi_util/nacl_ppapi_util.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/nacl_ppapi_util/ppapi_srpc_main.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/nacl_ppapi_util/ppapi_srpc_main.c View 1 1 chunk +64 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/nacl_ppapi_util/string_buffer.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/nacl_ppapi_util/string_buffer.cc View 1 1 chunk +65 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/pnacl_irt_shim/nacl.scons View 1 1 chunk +44 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.h View 1 1 chunk +21 lines, -0 lines 0 comments Download
A ppapi/native_client/src/untrusted/pnacl_support_extension/nacl.scons View 1 1 chunk +49 lines, -0 lines 0 comments Download
M ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py View 1 chunk +1 line, -1 line 0 comments Download
A ppapi/native_client/tests/nacl.scons View 1 1 chunk +68 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/browser_dynamic_library/browser_dlopen_test.cc View 1 1 chunk +59 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/browser_dynamic_library/browser_dlopen_test.html View 1 1 chunk +42 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/browser_dynamic_library/browser_dlopen_test.nmf View 1 chunk +16 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/browser_dynamic_library/nacl.scons View 1 1 chunk +45 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/browser_startup_time/browser_startup_time.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/browser_startup_time/browser_startup_time.js View 1 1 chunk +46 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/browser_startup_time/hello_world.cc View 1 1 chunk +62 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/browser_startup_time/nacl.scons View 1 1 chunk +73 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/exit_status/nacl.scons View 1 1 chunk +50 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/exit_status/pm_exit_status_test.cc View 1 1 chunk +136 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/exit_status/pm_exit_status_test.html View 1 1 chunk +64 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/fault_injection/fault_pm_nameservice_test.cc View 1 1 chunk +266 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/fault_injection/fault_pm_nameservice_test.html View 1 1 chunk +70 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/fault_injection/nacl.scons View 1 1 chunk +87 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/fault_injection/no_fault_pm_nameservice_test.html View 1 1 chunk +79 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/inbrowser_test_runner/nacl.scons View 1 1 chunk +60 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/inbrowser_test_runner/test_runner.html View 1 1 chunk +141 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/inbrowser_test_runner/test_runner_ppapi.c View 1 1 chunk +159 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/manifest_file/irt_manifest_file.nmf View 1 chunk +21 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/manifest_file/irt_manifest_file_test.cc View 1 1 chunk +122 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/manifest_file/irt_manifest_file_test.html View 1 1 chunk +50 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/manifest_file/nacl.scons View 1 1 chunk +109 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/manifest_file/pm_manifest_file.nmf View 1 chunk +21 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/manifest_file/pm_manifest_file_test.cc View 1 1 chunk +670 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/manifest_file/pm_manifest_file_test.html View 1 1 chunk +98 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/manifest_file/pm_pre_init_manifest_file.nmf View 1 chunk +21 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/manifest_file/pm_pre_init_manifest_file_test.cc View 1 1 chunk +269 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/manifest_file/pm_pre_init_manifest_file_test.html View 1 1 chunk +64 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/manifest_file/test_file.txt View 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/nameservice/nacl.scons View 1 1 chunk +41 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/nameservice/pm_nameservice_test.cc View 1 1 chunk +266 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/nameservice/pm_nameservice_test.html View 1 1 chunk +79 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/pnacl_client_translator/bad.pexe View 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/pnacl_client_translator/bad2.pexe View 1 chunk +36 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/pnacl_client_translator/nacl.scons View 1 1 chunk +104 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/pnacl_client_translator/pnacl_bad2_pexe.nmf View 1 chunk +8 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/pnacl_client_translator/pnacl_bad_doesnotexist.nmf View 1 chunk +8 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/pnacl_client_translator/pnacl_bad_doesnotexist_pexe_only.nmf View 1 chunk +5 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/pnacl_client_translator/pnacl_bad_pexe.nmf View 1 chunk +8 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/pnacl_client_translator/pnacl_bad_pexe_undefined_syms.nmf View 1 chunk +8 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/pnacl_client_translator/pnacl_bad_test.html View 1 1 chunk +157 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/pnacl_client_translator/pnacl_test_example.html View 1 1 chunk +108 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/postmessage_redir/nacl.scons View 1 1 chunk +58 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/postmessage_redir/pm_redir_test.cc View 1 1 chunk +195 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl_browser/postmessage_redir/pm_redir_test.html View 1 1 chunk +89 lines, -0 lines 0 comments Download
A ppapi/native_client/tools/browser_tester/browser_tester.py View 1 1 chunk +351 lines, -0 lines 0 comments Download
A ppapi/native_client/tools/browser_tester/browserdata/nacltest.js View 1 1 chunk +932 lines, -0 lines 0 comments Download
A ppapi/native_client/tools/browser_tester/browsertester/__init__.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
A ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py View 1 1 chunk +334 lines, -0 lines 0 comments Download
A ppapi/native_client/tools/browser_tester/browsertester/browserprocess.py View 1 1 chunk +76 lines, -0 lines 0 comments Download
A ppapi/native_client/tools/browser_tester/browsertester/rpclistener.py View 1 1 chunk +67 lines, -0 lines 0 comments Download
A ppapi/native_client/tools/browser_tester/browsertester/server.py View 1 1 chunk +246 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
bradn
The DEPS roll will likely get merged away. The buildbot script change is temporary for ...
8 years, 3 months ago (2012-09-06 07:57:46 UTC) #1
Nick Bray
http://codereview.chromium.org/10914053/diff/12002/chrome/test/nacl_test_injection/buildbot_nacl_integration.py File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right): http://codereview.chromium.org/10914053/diff/12002/chrome/test/nacl_test_injection/buildbot_nacl_integration.py#newcode159 chrome/test/nacl_test_injection/buildbot_nacl_integration.py:159: shutil.rmtree(os.path.join(nacl_dir, 'tests', 'nacl_browser')) Don't forget: DO NOT COMMIT. This ...
8 years, 3 months ago (2012-09-06 17:11:58 UTC) #2
bradn
PTAL http://codereview.chromium.org/10914053/diff/12002/chrome/test/nacl_test_injection/buildbot_nacl_integration.py File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right): http://codereview.chromium.org/10914053/diff/12002/chrome/test/nacl_test_injection/buildbot_nacl_integration.py#newcode159 chrome/test/nacl_test_injection/buildbot_nacl_integration.py:159: shutil.rmtree(os.path.join(nacl_dir, 'tests', 'nacl_browser')) On 2012/09/06 17:11:58, Nick Bray ...
8 years, 3 months ago (2012-09-06 18:53:16 UTC) #3
brettw
http://codereview.chromium.org/10914053/diff/3089/chrome/test/nacl_test_injection/buildbot_nacl_integration.py File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right): http://codereview.chromium.org/10914053/diff/3089/chrome/test/nacl_test_injection/buildbot_nacl_integration.py#newcode78 chrome/test/nacl_test_injection/buildbot_nacl_integration.py:78: # DO NOT COMMIT Is this on purpose?
8 years, 3 months ago (2012-09-06 20:13:21 UTC) #4
bradn
http://codereview.chromium.org/10914053/diff/3089/chrome/test/nacl_test_injection/buildbot_nacl_integration.py File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right): http://codereview.chromium.org/10914053/diff/3089/chrome/test/nacl_test_injection/buildbot_nacl_integration.py#newcode78 chrome/test/nacl_test_injection/buildbot_nacl_integration.py:78: # DO NOT COMMIT On 2012/09/06 20:13:21, brettw wrote: ...
8 years, 3 months ago (2012-09-06 20:28:26 UTC) #5
Nick Bray
Non-OWNER LGTM
8 years, 3 months ago (2012-09-07 21:35:02 UTC) #6
noelallen1
lgtm http://codereview.chromium.org/10914053/diff/5281/chrome/test/nacl_test_injection/buildbot_nacl_integration.py File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right): http://codereview.chromium.org/10914053/diff/5281/chrome/test/nacl_test_injection/buildbot_nacl_integration.py#newcode79 chrome/test/nacl_test_injection/buildbot_nacl_integration.py:79: nacl_dir = os.path.join(src_dir, 'native_client') Do not commit?
8 years, 3 months ago (2012-09-07 21:50:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/10914053/7200
8 years, 3 months ago (2012-09-07 22:16:20 UTC) #8
commit-bot: I haz the power
Presubmit check for 10914053-7200 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-07 22:16:51 UTC) #9
bradn
8 years, 3 months ago (2012-09-07 22:33:08 UTC) #10
noelallen_use_chromium
lgtm
8 years, 3 months ago (2012-09-07 23:05:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/10914053/7200
8 years, 3 months ago (2012-09-07 23:05:36 UTC) #12
commit-bot: I haz the power
Try job failure for 10914053-7200 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-09-08 01:11:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/10914053/17089
8 years, 3 months ago (2012-09-08 01:43:08 UTC) #14
commit-bot: I haz the power
8 years, 3 months ago (2012-09-08 09:48:44 UTC) #15 
Change committed as 155572

Powered by Google App Engine
This is Rietveld 408576698