Switch NaCl code to use GCC intrinsics for atomic ops.

Switch NaCl code to use GCC intrinsics for atomic ops.

Cleanup change to switch NaCl code to use GCC instrinsics.

BUG= none
TEST= compiles on all platforms

Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=9750

[Roland McGrath, 2012-09-15 01:07:01]

include/nacl/atomic_ops.h is already based on GCC intrinsics.
So you should just rename that and use it in both cases.

[petarj, 2012-09-15 01:25:52]

On 2012/09/15 01:07:01, Roland McGrath wrote:
> include/nacl/atomic_ops.h is already based on GCC intrinsics.
> So you should just rename that and use it in both cases.

Done.

[Mark Seaborn, 2012-09-15 02:53:51]

Please make the changes below and this will be good.

Thanks for doing this cleanup!

http://codereview.chromium.org/10913285/diff/4001/src/include/atomic_ops.h
File src/include/atomic_ops.h (right):

http://codereview.chromium.org/10913285/diff/4001/src/include/atomic_ops.h#ne...
src/include/atomic_ops.h:44: #if defined(__native_client__) ||
defined(NACL_LINUX)
This should be "#if defined(__native_client__) || NACL_LINUX".  NACL_LINUX is
always defined, as either 0 or 1.

http://codereview.chromium.org/10913285/diff/4001/src/include/atomic_ops.h#ne...
src/include/atomic_ops.h:45: #include
"native_client/src/include/nacl/atomic_ops.h"
Could you rename "nacl/atomic_ops.h" to "gcc/atomic_ops.h" to reflect that it's
not just used in NaCl untrusted code?

[petarj, 2012-09-15 23:13:17]

http://codereview.chromium.org/10913285/diff/4001/src/include/atomic_ops.h
File src/include/atomic_ops.h (right):

http://codereview.chromium.org/10913285/diff/4001/src/include/atomic_ops.h#ne...
src/include/atomic_ops.h:44: #if defined(__native_client__) ||
defined(NACL_LINUX)
On 2012/09/15 02:53:51, Mark Seaborn wrote:
> This should be "#if defined(__native_client__) || NACL_LINUX".  NACL_LINUX is
> always defined, as either 0 or 1.

Done.

http://codereview.chromium.org/10913285/diff/4001/src/include/atomic_ops.h#ne...
src/include/atomic_ops.h:45: #include
"native_client/src/include/nacl/atomic_ops.h"
On 2012/09/15 02:53:51, Mark Seaborn wrote:
> Could you rename "nacl/atomic_ops.h" to "gcc/atomic_ops.h" to reflect that
it's
> not just used in NaCl untrusted code?

Done.

[Mark Seaborn, 2012-09-15 23:25:06]

LGTM

[commit-bot: I haz the power, 2012-09-15 23:54:39]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/10913285/2002

[commit-bot: I haz the power, 2012-09-16 01:14:47]

Change committed as 9750