Issue 10913231: Issue 76: In Debugger Expressions view crashes on numeric property name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10913231: Issue 76: In Debugger Expressions view crashes on numeric property name (Closed)

Created:
8 years, 3 months ago by Peter Rybin

Modified:
8 years, 3 months ago

Reviewers:
apavlov

CC:
chromedevtools-codereview_googlegroups.com

Base URL:
https://chromedevtools.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Issue 76: In Debugger Expressions view crashes on numeric property name Committed: https://code.google.com/p/chromedevtools/source/detail?r=1068

Patch Set 2 : todo #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/StackFrame.java	View		1 chunk	+8 lines, -9 lines	2 comments	Download
	M	plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

apavlov

LGTM http://codereview.chromium.org/10913231/diff/3001/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/StackFrame.java File plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/StackFrame.java (right): http://codereview.chromium.org/10913231/diff/3001/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/StackFrame.java#newcode228 plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/StackFrame.java:228: return Long.valueOf(name.substring(1, len - 1)); What about number-like ...

8 years, 3 months ago (2012-09-13 03:27:08 UTC) #2

Peter Rybin

8 years, 3 months ago (2012-09-19 16:04:34 UTC) #3

http://codereview.chromium.org/10913231/diff/3001/plugins/org.chromium.debug....
File
plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/StackFrame.java
(right):

http://codereview.chromium.org/10913231/diff/3001/plugins/org.chromium.debug....
plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/StackFrame.java:228:
return Long.valueOf(name.substring(1, len - 1));
On 2012/09/13 03:27:09, apavlov wrote:
> What about number-like properties of arbitrary Long-evity?

These numbers are originally from Long from JSON parser, so there shouldn't be
any problems here. Plus we plan to redesign SDK API to handle this explicitly.

Expand Messages | Collapse Messages

Issue 10913231: Issue 76: In Debugger Expressions view crashes on numeric property name (Closed)

Description

Patch Set 1 #

Patch Set 2 : todo #

Messages