Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java

Issue 10913231: Issue 76: In Debugger Expressions view crashes on numeric property name (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: todo Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java
diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java
index 0ad259cbb94441f04e412a0a9e54fd1aae1bce33..c90ff507f5ae5b49c6e589eab070664d1236376c 100755
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java
+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java
@@ -35,7 +35,12 @@ public interface JsVariable {
JsValue getValue() throws UnsupportedOperationException;
/**
+ * Returns variable name. If the variable is an object property, in some implementations
+ * (namely V8 Standalone protocol) the numeric property name may be decorated
+ * with square brackets.
* @return the name of this variable
+ * TODO: do not decorate property name with square brackets,
+ * http://code.google.com/p/chromedevtools/issues/detail?id=77
*/
String getName();

Powered by Google App Engine
This is Rietveld 408576698