Reland DownloadManager::GetAllDownloads actually does now

content/public/browser/download_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadManager object manages the process of downloading, including
 // updates to the history system and providing the information for displaying
 // the downloads view in the Destinations tab. There is one DownloadManager per
 // active browser context in Chrome.
 //
 // Download observers:
@@ skipping 92 matching lines @@
   };
 
   typedef std::vector<DownloadItem*> DownloadVector;
 
   // If |dir_path| is empty, appends all temporary downloads to |*result|.
   // Otherwise, appends all temporary downloads that reside in |dir_path| to
   // |*result|.
   virtual void GetTemporaryDownloads(const FilePath& dir_path,
                                      DownloadVector* result) = 0;
 
-  // If |dir_path| is empty, appends all non-temporary downloads to |*result|.
-  // Otherwise, appends all non-temporary downloads that reside in |dir_path|
-  // to |*result|.
-  virtual void GetAllDownloads(const FilePath& dir_path,
-                               DownloadVector* result) = 0;
+  // Add all download items to |downloads|, no matter the type or state, without
+  // clearing |downloads| first.
+  virtual void GetAllDownloads(DownloadVector* downloads) = 0;
 
   // Returns all non-temporary downloads matching |query|. Empty query matches
   // everything.
   virtual void SearchDownloads(const string16& query,
                                DownloadVector* result) = 0;
 
   // Returns true if initialized properly.
   virtual bool Init(BrowserContext* browser_context) = 0;
 
   // Called by a download source (Currently DownloadResourceHandler)
@@ skipping 95 matching lines @@
  protected:
   virtual ~DownloadManager() {}
 
  private:
   friend class base::RefCountedThreadSafe<DownloadManager>;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DOWNLOAD_MANAGER_H_