Issue 10913010: Inlining monomorphic calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10913010: Inlining monomorphic calls. (Closed)

Created:
8 years, 3 months ago by zerny-google

Modified:
8 years, 3 months ago

Reviewers:
Kevin Millikin (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Inlining monomorphic calls. Landed by Kevin.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -115 lines)			Patch
M	runtime/vm/compiler.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph.h	View	1 2 3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	1 2 3	3 chunks	+10 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3	73 chunks	+35 lines, -82 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 2 3	8 chunks	+119 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zerny-google

This CL extends the inlining for monomorphic call sites based on IC feedback. This change ...

8 years, 3 months ago (2012-09-03 15:51:50 UTC) #1

Kevin Millikin (Google)

This change should be rebased on the new and improved (?) IL. I'm sorry.

8 years, 3 months ago (2012-09-05 12:53:02 UTC) #2

zerny-google

8 years, 3 months ago (2012-09-07 14:12:06 UTC) #3

This updates the CL for the new instructions. It also addresses Srdjan's
comments from the previous inlining CL.

Kevin: please feel free to land this CL next week if you like.

Expand Messages | Collapse Messages