Remove DownloadManager::GetDownloadItem in favor of GetDownload()

chrome/browser/plugin_installer.cc

Index: chrome/browser/plugin_installer.cc
diff --git a/chrome/browser/plugin_installer.cc b/chrome/browser/plugin_installer.cc
index 2904c5b2ea318a1a419282adf159a7993c0e575b..3ffc97fa3faced8ba59071cf64112c09c60d405b 100644
--- a/chrome/browser/plugin_installer.cc
+++ b/chrome/browser/plugin_installer.cc
@@ -225,8 +225,11 @@ void PluginInstaller::DownloadStarted(
     DownloadError(msg);
     return;
   }
-  DownloadItem* download_item =
-      dlm->GetActiveDownloadItem(download_id.local());
+  DownloadItem* download_item = dlm->GetDownload(download_id.local());

[Randy Smith (Not in Mondays), 2012/09/13 18:52:44]

I'd be inclined to put a DCHECK after this that we're in IN_PROGRESS.

[benjhayden, 2012/09/13 20:19:36]

TODone, see response to below comment.

+  if (!download_item) {
+    DownloadError("Download not found");
+    return;

[Randy Smith (Not in Mondays), 2012/09/13 18:52:44]

Why the addition of the error return?  GetDownload() will return NULL in fewer
cases than GetActiveDownloadItem.

[benjhayden, 2012/09/13 20:19:36]

We saw in WebstoreInstaller where the DownloadStarted callback may be called
with net::OK but an invalid id. This is just defensive programming while we hunt
that bug down. I'll add a TODO to turn it into a DCHECK when possible.

+  }
   download_item->SetOpenWhenComplete(true);
   download_item->AddObserver(this);
 }