Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4570)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/downloads_dom_handler.cc

Issue 10912183: Remove DownloadManager::GetDownloadItem in favor of GetDownload() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/plugin_installer.cc ('K') | « chrome/browser/plugin_installer.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | content/public/test/download_test_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/downloads_dom_handler.cc
diff --git a/chrome/browser/ui/webui/downloads_dom_handler.cc b/chrome/browser/ui/webui/downloads_dom_handler.cc
index be92a11a353bae762cca5328e4300147b70a4951..c9ffa3f8c84ec298bd25ea22986d415ff8fc9be8 100644
--- a/chrome/browser/ui/webui/downloads_dom_handler.cc
+++ b/chrome/browser/ui/webui/downloads_dom_handler.cc
@@ -500,9 +500,8 @@ void DownloadsDOMHandler::ShowDangerPrompt(
}
void DownloadsDOMHandler::DangerPromptAccepted(int download_id) {
- content::DownloadItem* item = download_manager_->GetActiveDownloadItem(
- download_id);
- if (!item)
+ content::DownloadItem* item = download_manager_->GetDownload(download_id);
+ if (!item || (item->GetState() != content::DownloadItem::IN_PROGRESS))
return;
CountDownloadsDOMEvents(DOWNLOADS_DOM_EVENT_SAVE_DANGEROUS);
item->DangerousDownloadValidated();
« chrome/browser/plugin_installer.cc ('K') | « chrome/browser/plugin_installer.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | content/public/test/download_test_observer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698