Replace the DownloadFileManager with direct ownership of DownloadFileImpl

content/browser/download/download_item_impl_delegate.cc

Index: content/browser/download/download_item_impl_delegate.cc
diff --git a/content/browser/download/download_item_impl_delegate.cc b/content/browser/download/download_item_impl_delegate.cc
index 4a889f77d24e5dc68b198fa70e16b162aeb9bd38..8910e8ed3f60cacb771ce9f931eee2cfb87a1a2f 100644
--- a/content/browser/download/download_item_impl_delegate.cc
+++ b/content/browser/download/download_item_impl_delegate.cc
@@ -2,9 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "base/logging.h"
 #include "content/browser/download/download_item_impl_delegate.h"
 
+#include "base/logging.h"
+
 class DownloadItemImpl;
 
 // Infrastructure in DownloadItemImplDelegate to assert invariant that
@@ -25,12 +26,15 @@ void DownloadItemImplDelegate::Detach() {
   --count_;
 }
 
-bool DownloadItemImplDelegate::ShouldOpenFileBasedOnExtension(
-    const FilePath& path) {
+void DownloadItemImplDelegate::DelegateStart(
+    DownloadItemImpl* download_item) {}

[asanka, 2012/09/24 20:43:53]

I know this is perfectly legitimate C++, but why provide a body to a pure
virtual method? Is the subclass supposed to call this?

[Randy Smith (Not in Mondays), 2012/09/26 21:01:05]

Fair point, but mooted by your other comment about changing the flow. 

+
+bool DownloadItemImplDelegate::ShouldOpenDownload(DownloadItemImpl* download) {
   return false;
 }
 
-bool DownloadItemImplDelegate::ShouldOpenDownload(DownloadItemImpl* download) {
+bool DownloadItemImplDelegate::ShouldOpenFileBasedOnExtension(
+    const FilePath& path) {
   return false;
 }