Replace the DownloadFileManager with direct ownership of DownloadFileImpl

content/browser/download/download_item_impl_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "content/browser/download/download_item_impl_delegate.h"
+
 #include "base/logging.h"
-#include "content/browser/download/download_item_impl_delegate.h"
 
 class DownloadItemImpl;
 
 // Infrastructure in DownloadItemImplDelegate to assert invariant that
 // delegate always outlives all attached DownloadItemImpls.
 DownloadItemImplDelegate::DownloadItemImplDelegate()
     : count_(0) {}
 
 DownloadItemImplDelegate::~DownloadItemImplDelegate() {
   DCHECK_EQ(0, count_);
 }
 
 void DownloadItemImplDelegate::Attach() {
   ++count_;
 }
 
 void DownloadItemImplDelegate::Detach() {
   DCHECK_LT(0, count_);
   --count_;
 }
 
+void DownloadItemImplDelegate::DelegateStart(
+    DownloadItemImpl* download_item) {}

[asanka, 2012/09/24 20:43:53]

I know this is perfectly legitimate C++, but why provide a body to a pure
virtual method? Is the subclass supposed to call this?

[Randy Smith (Not in Mondays), 2012/09/26 21:01:05]

Fair point, but mooted by your other comment about changing the flow. 

+
+bool DownloadItemImplDelegate::ShouldOpenDownload(DownloadItemImpl* download) {
+  return false;
+}
+
 bool DownloadItemImplDelegate::ShouldOpenFileBasedOnExtension(
     const FilePath& path) {
   return false;
 }
 
-bool DownloadItemImplDelegate::ShouldOpenDownload(DownloadItemImpl* download) {
-  return false;
-}
-
 void DownloadItemImplDelegate::CheckForFileRemoval(
     DownloadItemImpl* download_item) {}
 
 void DownloadItemImplDelegate::MaybeCompleteDownload(
     DownloadItemImpl* download) {}
 
 content::BrowserContext* DownloadItemImplDelegate::GetBrowserContext() const {
   return NULL;
 }
 
@@ skipping 10 matching lines @@
 void DownloadItemImplDelegate::DownloadRemoved(DownloadItemImpl* download) {}
 
 void DownloadItemImplDelegate::DownloadRenamedToIntermediateName(
     DownloadItemImpl* download) {}
 
 void DownloadItemImplDelegate::DownloadRenamedToFinalName(
     DownloadItemImpl* download) {}
 
 void DownloadItemImplDelegate::AssertStateConsistent(
     DownloadItemImpl* download) const {}