Replace the DownloadFileManager with direct ownership of DownloadFileImpl

content/shell/shell_download_manager_delegate.cc

Index: content/shell/shell_download_manager_delegate.cc
diff --git a/content/shell/shell_download_manager_delegate.cc b/content/shell/shell_download_manager_delegate.cc
index 5dfb4921678ec9c88ea2f8089ab59b2293cf8903..8290ea2d2f6f9f3152056fcebc71f046058f8bd4 100644
--- a/content/shell/shell_download_manager_delegate.cc
+++ b/content/shell/shell_download_manager_delegate.cc
@@ -111,7 +111,8 @@ void ShellDownloadManagerDelegate::OnDownloadPathGenerated(
   if (suppress_prompting_) {
     // Testing exit.
     callback.Run(suggested_path, DownloadItem::TARGET_DISPOSITION_OVERWRITE,
-                 DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS, suggested_path);
+                 DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
+                 suggested_path.AddExtension(FILE_PATH_LITERAL(".crdownload")));

[benjhayden, 2012/09/12 21:01:01]

Why do this in this CL?

[Randy Smith (Not in Mondays), 2012/09/13 20:15:12]

As it turns out, without this change, we don't *have* an intermediate name in
the content_browsertests, and we take the !NeedsRename() path.  This means we
can't test the commit point logic (cancel succeeds before, fails after) the same
way.  And the "real code" (chrome) always has an intermediate name, so making
the shell match that made sense to me.

     return;
   }