Replace the DownloadFileManager with direct ownership of DownloadFileImpl

content/shell/shell_download_manager_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/shell_download_manager_delegate.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 93 matching lines @@
 }
 
 void ShellDownloadManagerDelegate::OnDownloadPathGenerated(
     int32 download_id,
     const DownloadTargetCallback& callback,
     const FilePath& suggested_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (suppress_prompting_) {
     // Testing exit.
     callback.Run(suggested_path, DownloadItem::TARGET_DISPOSITION_OVERWRITE,
-                 DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS, suggested_path);
+                 DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
+                 suggested_path.AddExtension(FILE_PATH_LITERAL(".crdownload")));

[benjhayden, 2012/09/12 21:01:01]

Why do this in this CL?

[Randy Smith (Not in Mondays), 2012/09/13 20:15:12]

As it turns out, without this change, we don't *have* an intermediate name in
the content_browsertests, and we take the !NeedsRename() path.  This means we
can't test the commit point logic (cancel succeeds before, fails after) the same
way.  And the "real code" (chrome) always has an intermediate name, so making
the shell match that made sense to me.

     return;
   }
 
   ChooseDownloadPath(download_id, callback, suggested_path);
 }
 
 void ShellDownloadManagerDelegate::ChooseDownloadPath(
     int32 download_id,
     const DownloadTargetCallback& callback,
     const FilePath& suggested_path) {
@@ skipping 62 matching lines @@
       item->GetId(), --last_download_db_handle_);
 }
 
 void ShellDownloadManagerDelegate::SetDownloadBehaviorForTesting(
     const FilePath& default_download_path) {
   default_download_path_ = default_download_path;
   suppress_prompting_ = true;
 }
 
 }  // namespace content