Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: net/tools/get_server_time/get_server_time.cc

Issue 10912132: Move ProxyConfigService construction onto the IO thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adjust comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/get_server_time/get_server_time.cc
diff --git a/net/tools/get_server_time/get_server_time.cc b/net/tools/get_server_time/get_server_time.cc
index 3bbe271612a7b21ffe17e411a028440e01167501..1718004580728d4903b3956e40e711192502074b 100644
--- a/net/tools/get_server_time/get_server_time.cc
+++ b/net/tools/get_server_time/get_server_time.cc
@@ -41,6 +41,10 @@
#include "net/url_request/url_request_context_getter.h"
#include "net/url_request/url_request_status.h"
+#if defined(OS_LINUX) || defined(OS_OPENBSD)
digit1 2012/10/19 10:32:46 Any reason to include OS_OPENBSD here? It looks li
+#include <glib-object.h>
+#endif
+
#if defined(OS_MACOSX)
#include "base/mac/scoped_nsautorelease_pool.h"
#elif defined(OS_LINUX)
@@ -170,15 +174,11 @@ class PrintingLog : public net::NetLog {
};
// Builds a URLRequestContext assuming there's only a single loop.
-scoped_ptr<net::URLRequestContext> BuildURLRequestContext() {
+scoped_ptr<net::URLRequestContext> BuildURLRequestContext(
+ const scoped_refptr<base::SingleThreadTaskRunner>& main_task_runner) {
net::URLRequestContextBuilder builder;
#if defined(OS_LINUX)
- // On Linux, use a fixed ProxyConfigService, since the default one
- // depends on glib.
- //
- // TODO(akalin): Remove this once http://crbug.com/146421 is fixed.
- builder.set_proxy_config_service(
- new net::ProxyConfigServiceFixed(net::ProxyConfig()));
+ builder.set_glib_task_runner(main_task_runner);
#endif
scoped_ptr<net::URLRequestContext> context(builder.Build());
context->set_net_log(new PrintingLog());
@@ -191,7 +191,7 @@ class SingleThreadRequestContextGetter : public net::URLRequestContextGetter {
// about when |context_| gets created.
explicit SingleThreadRequestContextGetter(
const scoped_refptr<base::SingleThreadTaskRunner>& main_task_runner)
- : context_(BuildURLRequestContext()),
+ : context_(BuildURLRequestContext(main_task_runner)),
main_task_runner_(main_task_runner) {}
virtual net::URLRequestContext* GetURLRequestContext() OVERRIDE {
@@ -252,6 +252,11 @@ int main(int argc, char* argv[]) {
#if defined(OS_MACOSX)
base::mac::ScopedNSAutoreleasePool pool;
#endif
+#if defined(OS_LINUX) || defined(OS_OPENBSD)
+ // Needed so ProxyConfigServiceLinux can use gconf.
+ // Normally handled by BrowserMainLoop::InitializeToolkit().
+ g_type_init();
+#endif
base::AtExitManager exit_manager;
CommandLine::Init(argc, argv);

Powered by Google App Engine
This is Rietveld 408576698