Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4909)

Unified Diff: net/proxy/proxy_service.h

Issue 10912132: Move ProxyConfigService construction onto the IO thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adjust comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_service.h
diff --git a/net/proxy/proxy_service.h b/net/proxy/proxy_service.h
index 3d894202591e5b016742551cf4afaf806fa24909..3ac4be33c948c66b289bdbfdf1a93560491861a4 100644
--- a/net/proxy/proxy_service.h
+++ b/net/proxy/proxy_service.h
@@ -201,6 +201,9 @@ class NET_EXPORT ProxyService : public NetworkChangeNotifier::IPAddressObserver,
// to downloading and testing the PAC files.
void ForceReloadProxyConfig();
+ // Give ProxyConfigService a chance to perform shutdown work.
+ void StartTearDown();
+
// Same as CreateProxyServiceUsingV8ProxyResolver, except it uses system
// libraries for evaluating the PAC script if available, otherwise skips
// proxy autoconfig.
@@ -234,7 +237,7 @@ class NET_EXPORT ProxyService : public NetworkChangeNotifier::IPAddressObserver,
// Creates a config service appropriate for this platform that fetches the
// system proxy settings.
static ProxyConfigService* CreateSystemProxyConfigService(
- base::SingleThreadTaskRunner* io_thread_task_runner,
+ base::SingleThreadTaskRunner* glib_thread_task_runner,
digit1 2012/10/19 10:32:46 Probably use main_thread_task_runner here.
MessageLoop* file_loop);
// This method should only be used by unit tests.

Powered by Google App Engine
This is Rietveld 408576698