Enable robust decoding of custom wallpaper and allow custom wallpaper on login page

+ Ensure that OnRobustJPEGDecodeImage only uses the codec of our choosing (IJGlibjpeg at the moment).
+ Solve CrOS boot time hang when image decoding fail in utility process.
+ Enforce Robust JPEG decoding of Wallpaper image, -> and as a result re-enable custom wallpapers rendering on the login page.

BUG=143198, 144296, 144999
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154330

[Emmanuel Saint-loubert-Bié, 2012-08-30 18:09:00]

Hello Sky,

This should be one of the last CL for this issue. Thanks!

-- Emmnanuel

[sky, 2012-08-30 19:31:04]

http://codereview.chromium.org/10912019/diff/1008/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/user_image_loader.cc (right):

http://codereview.chromium.org/10912019/diff/1008/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/user_image_loader.cc:34: :
target_message_loop_(NULL), image_codec_(image_codec) {
If the member initializer list is wrapped to a new line, then each member should
be on its own line.

http://codereview.chromium.org/10912019/diff/1008/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/user_image_loader.cc:115: static UserImage
empty_image;
Statics should only be of primitive types. I think you can remove empty_image
entirely and do: base::Bind(image_info.loaded_cb, UserImage())

http://codereview.chromium.org/10912019/diff/1008/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/user_manager_impl.cc (right):

http://codereview.chromium.org/10912019/diff/1008/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/user_manager_impl.cc:191: :
ALLOW_THIS_IN_INITIALIZER_LIST(
Remove ALLOW_THIS_IN...

[Emmanuel Saint-loubert-Bié, 2012-08-30 21:02:52]

Scott,

Applied your comments. PTAL.

http://codereview.chromium.org/10912019/diff/1008/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/user_image_loader.cc (right):

http://codereview.chromium.org/10912019/diff/1008/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/user_image_loader.cc:34: :
target_message_loop_(NULL), image_codec_(image_codec) {
On 2012/08/30 19:31:05, sky wrote:
> If the member initializer list is wrapped to a new line, then each member
should
> be on its own line.

Done.

http://codereview.chromium.org/10912019/diff/1008/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/user_manager_impl.cc (right):

http://codereview.chromium.org/10912019/diff/1008/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/user_manager_impl.cc:191: :
ALLOW_THIS_IN_INITIALIZER_LIST(
On 2012/08/30 19:31:05, sky wrote:
> Remove ALLOW_THIS_IN...

Done.

[sky, 2012-08-30 21:14:29]

LGTM

[commit-bot: I haz the power, 2012-08-30 21:53:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/saintlou@chromium.org/10912019/4002

[commit-bot: I haz the power, 2012-08-30 23:24:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/saintlou@chromium.org/10912019/5003