Issue 10911306: Split Drive test utilities to drive_test_util and gdata_test_util

Issue 10911306: Split Drive test utilities to drive_test_util and gdata_test_util (Closed)

Created:
8 years, 3 months ago by nhiroki

Modified:
8 years, 3 months ago

Reviewers:
Lei Zhang, satorux1, kochi

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, kinuko

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Split Drive test utilities to drive_test_util and gdata_test_util BUG=127855 TEST=unit_tests, browser_tests TBR=thestig@chromium.org for .gypi change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156800

Patch Set 2 : Reflect comments #

Patch Set 3 : Fix chrome_tests.gypi #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -81 lines)			Patch
M	chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_test_util.h	View		3 chunks	+1 line, -17 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_test_util.cc	View		2 chunks	+0 lines, -61 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_operations_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/chromeos/gdata/gdata_test_util.h	View	1 2	1 chunk	+43 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/gdata/gdata_test_util.cc	View		1 chunk	+77 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

kochi

lgtm with nit. http://codereview.chromium.org/10911306/diff/1/chrome/browser/chromeos/gdata/gdata_test_util.h File chrome/browser/chromeos/gdata/gdata_test_util.h (right): http://codereview.chromium.org/10911306/diff/1/chrome/browser/chromeos/gdata/gdata_test_util.h#newcode17 chrome/browser/chromeos/gdata/gdata_test_util.h:17: Don't need this blank line. http://codereview.chromium.org/10911306/diff/1/chrome/browser/chromeos/gdata/gdata_test_util.h#newcode38 ...

8 years, 3 months ago (2012-09-14 11:05:15 UTC) #2

nhiroki

Thank you very much! http://codereview.chromium.org/10911306/diff/1/chrome/browser/chromeos/gdata/gdata_test_util.h File chrome/browser/chromeos/gdata/gdata_test_util.h (right): http://codereview.chromium.org/10911306/diff/1/chrome/browser/chromeos/gdata/gdata_test_util.h#newcode17 chrome/browser/chromeos/gdata/gdata_test_util.h:17: On 2012/09/14 11:05:15, Takayoshi Kochi ...

8 years, 3 months ago (2012-09-14 11:12:05 UTC) #3