Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5578)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc

Issue 10911300: Move ExtensionAction from common/ to browser/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: proof of concept Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc
index 6b2c39d02fac821bd9bbafcc15c824d979840942..46da7416441069e5d2b0b44c42385ab57328d133 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc
@@ -4,7 +4,6 @@
#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
-#include "chrome/common/extensions/extension_action.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
#include "chrome/common/extensions/extension_switch_utils.h"
#include "grit/theme_resources.h"
@@ -42,10 +41,8 @@ TEST_F(ExtensionManifestTest, ScriptBadgeBasic) {
EXPECT_THAT(StripMissingFlagWarning(extension->install_warnings()),
testing::ElementsAre(/*empty*/));
- EXPECT_EQ("my extension", extension->script_badge()->GetTitle(
- ExtensionAction::kDefaultTabId));
- EXPECT_TRUE(extension->script_badge()->HasPopup(
- ExtensionAction::kDefaultTabId));
+ EXPECT_EQ("my extension", extension->script_badge()->default_title);
+ EXPECT_FALSE(extension->script_badge()->default_popup_url.is_empty());
EXPECT_TRUE(ImagesAreEqual(
ui::ResourceBundle::GetSharedInstance().GetImageNamed(
IDR_EXTENSIONS_FAVICON),

Powered by Google App Engine
This is Rietveld 408576698