Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc

Issue 10911300: Move ExtensionAction from common/ to browser/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: proof of concept Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "chrome/common/extensions/extension_action.h"
8 #include "chrome/common/extensions/extension_manifest_constants.h" 7 #include "chrome/common/extensions/extension_manifest_constants.h"
9 #include "chrome/common/extensions/extension_switch_utils.h" 8 #include "chrome/common/extensions/extension_switch_utils.h"
10 #include "grit/theme_resources.h" 9 #include "grit/theme_resources.h"
11 #include "testing/gmock/include/gmock/gmock.h" 10 #include "testing/gmock/include/gmock/gmock.h"
12 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
13 #include "ui/base/resource/resource_bundle.h" 12 #include "ui/base/resource/resource_bundle.h"
14 #include "ui/gfx/image/image.h" 13 #include "ui/gfx/image/image.h"
15 #include "ui/gfx/skia_util.h" 14 #include "ui/gfx/skia_util.h"
16 15
17 namespace errors = extension_manifest_errors; 16 namespace errors = extension_manifest_errors;
(...skipping 17 matching lines...) Expand all
35 } 34 }
36 35
37 TEST_F(ExtensionManifestTest, ScriptBadgeBasic) { 36 TEST_F(ExtensionManifestTest, ScriptBadgeBasic) {
38 scoped_refptr<Extension> extension( 37 scoped_refptr<Extension> extension(
39 LoadAndExpectSuccess("script_badge_basic.json")); 38 LoadAndExpectSuccess("script_badge_basic.json"));
40 ASSERT_TRUE(extension.get()); 39 ASSERT_TRUE(extension.get());
41 ASSERT_TRUE(extension->script_badge()); 40 ASSERT_TRUE(extension->script_badge());
42 EXPECT_THAT(StripMissingFlagWarning(extension->install_warnings()), 41 EXPECT_THAT(StripMissingFlagWarning(extension->install_warnings()),
43 testing::ElementsAre(/*empty*/)); 42 testing::ElementsAre(/*empty*/));
44 43
45 EXPECT_EQ("my extension", extension->script_badge()->GetTitle( 44 EXPECT_EQ("my extension", extension->script_badge()->default_title);
46 ExtensionAction::kDefaultTabId)); 45 EXPECT_FALSE(extension->script_badge()->default_popup_url.is_empty());
47 EXPECT_TRUE(extension->script_badge()->HasPopup(
48 ExtensionAction::kDefaultTabId));
49 EXPECT_TRUE(ImagesAreEqual( 46 EXPECT_TRUE(ImagesAreEqual(
50 ui::ResourceBundle::GetSharedInstance().GetImageNamed( 47 ui::ResourceBundle::GetSharedInstance().GetImageNamed(
51 IDR_EXTENSIONS_FAVICON), 48 IDR_EXTENSIONS_FAVICON),
52 extension->script_badge()->GetIcon(ExtensionAction::kDefaultTabId))); 49 extension->script_badge()->GetIcon(ExtensionAction::kDefaultTabId)));
53 EXPECT_EQ("icon16.png", extension->script_badge()->default_icon_path()); 50 EXPECT_EQ("icon16.png", extension->script_badge()->default_icon_path());
54 } 51 }
55 52
56 TEST_F(ExtensionManifestTest, ScriptBadgeExplicitTitleAndIconsIgnored) { 53 TEST_F(ExtensionManifestTest, ScriptBadgeExplicitTitleAndIconsIgnored) {
57 scoped_refptr<Extension> extension( 54 scoped_refptr<Extension> extension(
58 LoadAndExpectSuccess("script_badge_title_icons_ignored.json")); 55 LoadAndExpectSuccess("script_badge_title_icons_ignored.json"));
(...skipping 27 matching lines...) Expand all
86 83
87 EXPECT_EQ("", extension->script_badge()->default_icon_path()) 84 EXPECT_EQ("", extension->script_badge()->default_icon_path())
88 << "Should not fall back to the 64px icon."; 85 << "Should not fall back to the 64px icon.";
89 EXPECT_FALSE(extension->script_badge()->GetIcon( 86 EXPECT_FALSE(extension->script_badge()->GetIcon(
90 ExtensionAction::kDefaultTabId).IsEmpty()) 87 ExtensionAction::kDefaultTabId).IsEmpty())
91 << "Should set the puzzle piece as the default, but there's no way " 88 << "Should set the puzzle piece as the default, but there's no way "
92 << "to assert in a unittest what the image looks like."; 89 << "to assert in a unittest what the image looks like.";
93 } 90 }
94 91
95 } // namespace 92 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698