Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/media_gallery/media_file_system_registry.cc

Issue 10911242: make media gallery directory tooltips in media gallery config dialog absolute paths (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_gallery/media_file_system_registry.cc
diff --git a/chrome/browser/media_gallery/media_file_system_registry.cc b/chrome/browser/media_gallery/media_file_system_registry.cc
index 9a39533db94c0b574afc37a1d809226924d10562..b1164526e983f024b957a4cc5144f1fa9d001f07 100644
--- a/chrome/browser/media_gallery/media_file_system_registry.cc
+++ b/chrome/browser/media_gallery/media_file_system_registry.cc
@@ -111,13 +111,11 @@ class ExtensionGalleriesHost
const std::string& device_id = gallery_info.device_id;
// TODO(kmadhusu) handle MTP devices.
DCHECK(MediaStorageUtil::IsMassStorageDevice(device_id));
- FilePath path = MediaStorageUtil::FindDevicePathById(device_id);
+ FilePath path = gallery_info.AbsolutePath();
// TODO(vandebo) we also need to check that these galleries are attached.
// For now, just skip over entries that we couldn't find.
- if (path.empty())
+ if (!path.IsAbsolute())
continue;
- CHECK(!path.empty());
- path = path.Append(gallery_info.path);
MediaFileSystemRegistry::MediaFSInfo new_entry;
new_entry.name = gallery_info.display_name;

Powered by Google App Engine
This is Rietveld 408576698