Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 10911242: make media gallery directory tooltips in media gallery config dialog absolute paths (Closed)

Created:
8 years, 3 months ago by Evan Stade
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, tfarina
Visibility:
Public.

Description

make media gallery directory tooltips in media gallery config dialog absolute paths rather than relative paths BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157129

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix broken unit tests #

Patch Set 3 : mac compile #

Patch Set 4 : another mac fix #

Patch Set 5 : fix typo #

Patch Set 6 : sync #

Patch Set 7 : +! #

Messages

Total messages: 12 (0 generated)
Evan Stade
vandebo: review sail: cocoa/ stamp sky: views/ stamp
8 years, 3 months ago (2012-09-12 09:58:19 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-09-12 14:34:25 UTC) #2
vandebo (ex-Chrome)
LGTM http://codereview.chromium.org/10911242/diff/1/chrome/browser/media_gallery/media_galleries_preferences.h File chrome/browser/media_gallery/media_galleries_preferences.h (right): http://codereview.chromium.org/10911242/diff/1/chrome/browser/media_gallery/media_galleries_preferences.h#newcode39 chrome/browser/media_gallery/media_galleries_preferences.h:39: struct MediaGalleryPrefInfo { Adding this method means this ...
8 years, 3 months ago (2012-09-12 18:19:57 UTC) #3
sail
cocoa/* LGTM
8 years, 3 months ago (2012-09-12 18:37:58 UTC) #4
vandebo (ex-Chrome)
estade: ping...
8 years, 3 months ago (2012-09-13 21:01:02 UTC) #5
Evan Stade
On 2012/09/13 21:01:02, vandebo wrote: > estade: ping... it broke tests. I had to fix ...
8 years, 3 months ago (2012-09-14 09:20:41 UTC) #6
vandebo (ex-Chrome)
Looks like you might have got it working. Trying the CQ...
8 years, 3 months ago (2012-09-14 16:39:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10911242/3003
8 years, 3 months ago (2012-09-14 16:39:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10911242/3003
8 years, 3 months ago (2012-09-14 17:41:55 UTC) #9
commit-bot: I haz the power
Failed to apply patch for chrome/browser/media_gallery/media_file_system_registry.cc: While running patch -p1 --forward --force; patching file chrome/browser/media_gallery/media_file_system_registry.cc ...
8 years, 3 months ago (2012-09-14 18:53:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10911242/14002
8 years, 3 months ago (2012-09-17 09:33:42 UTC) #11
commit-bot: I haz the power
8 years, 3 months ago (2012-09-17 11:22:54 UTC) #12
Retried try job too often for step(s) browser_tests

Powered by Google App Engine
This is Rietveld 408576698