Chrome OS should open to empty desktop when session restore is empty.

Chrome OS should open to empty desktop when session restore is empty.
Also remove code that opened empty browser behind getting started guide for new users.

BUG=141718, 148675
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156517

[sky, 2012-09-11 18:23:58]

http://codereview.chromium.org/10911222/diff/1/chrome/browser/defaults.h
File chrome/browser/defaults.h (right):

http://codereview.chromium.org/10911222/diff/1/chrome/browser/defaults.h#newc...
chrome/browser/defaults.h:90: extern const bool
kAlwaysCreateTabbedBrowserOnStartup;
This name is misleading. This only applies during session restore. It should be
something like:

// Indicates whether session restore should always create a new
// tabbed browser. This is true every where except on chromeos
// where we want the desktop to show through in this situation.
kAlwaysCreateTabbedBrowserOnSessionRestore;

[Nikita (slow), 2012-09-11 18:52:50]

http://codereview.chromium.org/10911222/diff/1/chrome/browser/defaults.h
File chrome/browser/defaults.h (right):

http://codereview.chromium.org/10911222/diff/1/chrome/browser/defaults.h#newc...
chrome/browser/defaults.h:90: extern const bool
kAlwaysCreateTabbedBrowserOnStartup;
On 2012/09/11 18:23:59, sky wrote:
> This name is misleading. This only applies during session restore. It should
be
> something like:
> 
> // Indicates whether session restore should always create a new
> // tabbed browser. This is true every where except on chromeos
> // where we want the desktop to show through in this situation.
> kAlwaysCreateTabbedBrowserOnSessionRestore;

Done.

[sky, 2012-09-11 19:35:03]

LGTM

[commit-bot: I haz the power, 2012-09-11 19:37:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10911222/3011

[commit-bot: I haz the power, 2012-09-11 21:17:24]

Try job failure for 10911222-3011 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Nikita (slow), 2012-09-12 14:57:27]

Scott, PTAL

I had to add additional switch so that 3 tests that rely on session restore are
not failing. Fixing those would require
a. fixing http://crbug.com/119175 first
b. Refactoring InProcessBrowserTest so that it doesn't rely on BrowserList when
accessing Browser instance and Profile instance through Browser*.

See http://crbug.com/148675 for more details

[sky, 2012-09-12 15:07:20]

LGTM

http://codereview.chromium.org/10911222/diff/3012/chrome/browser/ui/startup/s...
File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right):

http://codereview.chromium.org/10911222/diff/3012/chrome/browser/ui/startup/s...
chrome/browser/ui/startup/startup_browser_creator_impl.cc:609:
switches::kCreateBrowserOnStartupForTests)) {
I suspect this doesn't compile since the switch is only defined on chromeos.
Make the switch defined every where.

http://codereview.chromium.org/10911222/diff/3012/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10911222/diff/3012/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:1365: // this switch so that at list one
browser instance is created on startup.
list -> least

[Nikita (slow), 2012-09-12 15:13:31]

http://codereview.chromium.org/10911222/diff/3012/chrome/browser/ui/startup/s...
File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right):

http://codereview.chromium.org/10911222/diff/3012/chrome/browser/ui/startup/s...
chrome/browser/ui/startup/startup_browser_creator_impl.cc:609:
switches::kCreateBrowserOnStartupForTests)) {
On 2012/09/12 15:07:20, sky wrote:
> I suspect this doesn't compile since the switch is only defined on chromeos.
> Make the switch defined every where.

Done.

http://codereview.chromium.org/10911222/diff/3012/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10911222/diff/3012/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:1365: // this switch so that at list one
browser instance is created on startup.
On 2012/09/12 15:07:20, sky wrote:
> list -> least

Done.

[commit-bot: I haz the power, 2012-09-13 07:24:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10911222/13003

[commit-bot: I haz the power, 2012-09-13 09:47:40]

Change committed as 156517