Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: sync/protocol/device_info_specifics.proto

Issue 10911073: NOT FOR COMMIT: Add DeviceInfo type and ChangeProcessor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Introduce SyncedDeviceTracker (the ChangeProcessor) Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 //
5 // Sync protocol datatype extension for nigori keys.
6
7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
8 // any fields in this file.
9
10 syntax = "proto2";
11
12 option optimize_for = LITE_RUNTIME;
13 option retain_unknown_fields = true;
14
15 package sync_pb;
16
17 // Information about a device that is running a sync-enabled Chrome browser.
18 // We are mapping the unique per-device cache guid to more specific information
19 // about the device.
20 message DeviceInfoSpecifics {
rlarocque 2012/09/14 01:03:07 Feel free to question the contents of this proto.
21 optional string cache_guid = 1;
Nicolas Zea 2012/09/13 00:45:55 comment about this field
rlarocque 2012/09/14 01:03:07 Done.
22
23 // The name of the device is dependent on the OS running the Chrome instance.
24 // On a Chromebook this is "Chromebook", on Linux the distribution name, on
Nicolas Zea 2012/09/13 00:45:55 I don't think it's necessarily worth enumerating a
rlarocque 2012/09/14 01:03:07 Done.
25 // Mac OSX the hadware model name and on Windows the computer name.
26 optional string name = 2;
Raz Mathias 2012/09/13 16:07:01 Is this field for UI display or programatic use?
rlarocque 2012/09/14 01:03:07 The value of this field comes from GetSessionNameS
27
28 // The platform of the device (ChromeOS, Linux, Mac, or Windows).
29 optional string platform = 3;
Nicolas Zea 2012/09/13 00:45:55 Note that we have an enum for the supported platfo
rlarocque 2012/09/14 01:03:07 That sounds reasonable. Will do.
30
Raz Mathias 2012/09/13 16:07:01 I presume nzea means the SessionHeader.DeviceType.
31 // The Chrome version of the sync-enabled Chrome browser.
32 optional string chrome_version = 4;
Raz Mathias 2012/09/13 16:07:01 We already have functions to extract this info ser
rlarocque 2012/09/14 01:03:07 The client will set this. It uses the same functi
33 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698