NOT FOR COMMIT: Add DeviceInfo type and ChangeProcessor

chrome/browser/sync/glue/change_processor.cc

Index: chrome/browser/sync/glue/change_processor.cc
diff --git a/chrome/browser/sync/glue/change_processor.cc b/chrome/browser/sync/glue/change_processor.cc
index 41fcf2b074cc50fe2f6fadb779d25b231077b4bf..4b30352ef758e6015dbdaab8e74c40756bcd28c9 100644
--- a/chrome/browser/sync/glue/change_processor.cc
+++ b/chrome/browser/sync/glue/change_processor.cc
@@ -18,7 +18,7 @@ ChangeProcessor::~ChangeProcessor() {
 
 void ChangeProcessor::Start(Profile* profile,
                             syncer::UserShare* share_handle) {
-  DCHECK(error_handler_ && !share_handle_);
+  DCHECK(!share_handle_);

[rlarocque, 2012/09/08 01:20:44]

This is unfortunate.  The only implementation of DataTypeErrorHandler is a
DataTypeController.  DeviceInfo doesn't have a DataTypeController.

This makes me think that the abstract ChangeProcessor class is overreaching a
bit.  There is room for another ChangeProcessorInterface class that would not
require a DataTypeErrorHandler.

   share_handle_ = share_handle;
   StartImpl(profile);
   running_ = true;