NOT FOR COMMIT: Add DeviceInfo type and ChangeProcessor

chrome/browser/sync/glue/change_processor.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/change_processor.h"
 #include "chrome/browser/profiles/profile.h"
 
 namespace browser_sync {
 
 ChangeProcessor::ChangeProcessor(DataTypeErrorHandler* error_handler)
     : running_(false),
       error_handler_(error_handler),
       share_handle_(NULL) {}
 
 ChangeProcessor::~ChangeProcessor() {
   DCHECK(!running_) << "ChangeProcessor dtor while running";
 }
 
 void ChangeProcessor::Start(Profile* profile,
                             syncer::UserShare* share_handle) {
-  DCHECK(error_handler_ && !share_handle_);
+  DCHECK(!share_handle_);

[rlarocque, 2012/09/08 01:20:44]

This is unfortunate.  The only implementation of DataTypeErrorHandler is a
DataTypeController.  DeviceInfo doesn't have a DataTypeController.

This makes me think that the abstract ChangeProcessor class is overreaching a
bit.  There is room for another ChangeProcessorInterface class that would not
require a DataTypeErrorHandler.

   share_handle_ = share_handle;
   StartImpl(profile);
   running_ = true;
 }
 
 void ChangeProcessor::Stop() {
   if (!running_)
     return;
   StopImpl();
   share_handle_ = NULL;
   running_ = false;
 }
 
 bool ChangeProcessor::IsRunning() const {
   return running_;
 }
 
 // Not implemented by default.
 void ChangeProcessor::CommitChangesFromSyncModel() {}
 
 DataTypeErrorHandler* ChangeProcessor::error_handler() const {
   return error_handler_;
 }
 
 syncer::UserShare* ChangeProcessor::share_handle() const {
   return share_handle_;
 }
 
 }  // namespace browser_sync