Collect the types used in is-checks in the resolver phase.

lib/compiler/implementation/compiler.dart

Index: lib/compiler/implementation/compiler.dart
diff --git a/lib/compiler/implementation/compiler.dart b/lib/compiler/implementation/compiler.dart
index 23797006b1f4a05d250d98e8961a7876c762c991..cafe2d5d0cc5129aa86574daac08c1efa68cb2eb 100644
--- a/lib/compiler/implementation/compiler.dart
+++ b/lib/compiler/implementation/compiler.dart
@@ -343,6 +343,14 @@ class Compiler implements DiagnosticListener {
 
     jsIndexingBehaviorInterface =
         findHelper(const SourceString('JavaScriptIndexingBehavior'));
+
+    // Register is-checks for all special classes.

[ngeoffray, 2012/08/30 11:03:33]

Why? Is checks are for emitting the is$ClassName method on user-defined classes,
so I don't think special classed need it.

[karlklose, 2012/08/30 13:04:31]

Done.

I added internalErrors when elements were not found in the isChecks set, where
they before this change have been added in the backend. Adding these was
necessary to not trigger these errors.

However, after removing this and the internalErrors in the backend, all tests
pass. So it seems that adding the isChecks in the backend was unnecessary.

+    for (ClassElement cls in [objectClass, boolClass, numClass, intClass,
+                              doubleClass, stringClass, functionClass,
+                              listClass, closureClass, dynamicClass,
+                              jsIndexingBehaviorInterface]) {
+      registerIsCheck(cls.computeType(this));
+    }
   }
 
   void scanBuiltinLibraries() {
@@ -359,9 +367,6 @@ class Compiler implements DiagnosticListener {
     assertMethod = coreLibrary.find(const SourceString('assert'));
 
     initializeSpecialClasses();
-
-    //patchDartLibrary(coreLibrary, 'core');
-    //patchDartLibrary(coreImplLibrary, 'coreimpl');
   }
 
   void importCoreLibrary(LibraryElement library) {
@@ -833,6 +838,11 @@ class Compiler implements DiagnosticListener {
       => interceptorsLibrary.findLocal(name);
 
   bool get isMockCompilation => false;
+
+  registerIsCheck(Type type) {

[ngeoffray, 2012/08/30 11:03:33]

Please remove this helper method, it is too confusing to have it there and in
enqueuer.

[karlklose, 2012/08/30 13:04:31]

Done.

+    enqueuer.codegen.registerIsCheck(type);
+    enqueuer.resolution.registerIsCheck(type);
+  }
 }
 
 class CompilerTask {