Collect the types used in is-checks in the resolver phase.

lib/compiler/implementation/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 /**
  * If true, print a warning for each method that was resolved, but not
  * compiled.
  */
 const bool REPORT_EXCESS_RESOLUTION = false;
@@ skipping 325 matching lines @@
     closureClass = lookupSpecialClass(const SourceString('Closure'));
     dynamicClass = lookupSpecialClass(const SourceString('Dynamic'));
     nullClass = lookupSpecialClass(const SourceString('Null'));
     types = new Types(this, dynamicClass);
     if (!coreLibValid) {
       cancel('core library does not contain required classes');
     }
 
     jsIndexingBehaviorInterface =
         findHelper(const SourceString('JavaScriptIndexingBehavior'));
+
+    // Register is-checks for all special classes.

[ngeoffray, 2012/08/30 11:03:33]

Why? Is checks are for emitting the is$ClassName method on user-defined classes,
so I don't think special classed need it.

[karlklose, 2012/08/30 13:04:31]

Done.

I added internalErrors when elements were not found in the isChecks set, where
they before this change have been added in the backend. Adding these was
necessary to not trigger these errors.

However, after removing this and the internalErrors in the backend, all tests
pass. So it seems that adding the isChecks in the backend was unnecessary.

+    for (ClassElement cls in [objectClass, boolClass, numClass, intClass,
+                              doubleClass, stringClass, functionClass,
+                              listClass, closureClass, dynamicClass,
+                              jsIndexingBehaviorInterface]) {
+      registerIsCheck(cls.computeType(this));
+    }
   }
 
   void scanBuiltinLibraries() {
     coreImplLibrary = scanBuiltinLibrary('coreimpl');
     jsHelperLibrary = scanBuiltinLibrary('_js_helper');
     interceptorsLibrary = scanBuiltinLibrary('_interceptors');
 
     addForeignFunctions(jsHelperLibrary);
     addForeignFunctions(interceptorsLibrary);
 
     libraries['dart:core'] = coreLibrary;
     libraries['dart:coreimpl'] = coreImplLibrary;
 
     assertMethod = coreLibrary.find(const SourceString('assert'));
 
     initializeSpecialClasses();
-
-    //patchDartLibrary(coreLibrary, 'core');
-    //patchDartLibrary(coreImplLibrary, 'coreimpl');
   }
 
   void importCoreLibrary(LibraryElement library) {
     Uri coreUri = new Uri.fromComponents(scheme: 'dart', path: 'core');
     if (coreLibrary === null) {
       coreLibrary = scanner.loadLibrary(coreUri, null, coreUri);
     }
     scanner.importLibrary(library,
                           coreLibrary,
                           null,
@@ skipping 451 matching lines @@
   String get legDirectory {
     unimplemented('Compiler.legDirectory');
   }
 
   Element findHelper(SourceString name)
       => jsHelperLibrary.findLocal(name);
   Element findInterceptor(SourceString name)
       => interceptorsLibrary.findLocal(name);
 
   bool get isMockCompilation => false;
+
+  registerIsCheck(Type type) {

[ngeoffray, 2012/08/30 11:03:33]

Please remove this helper method, it is too confusing to have it there and in
enqueuer.

[karlklose, 2012/08/30 13:04:31]

Done.

+    enqueuer.codegen.registerIsCheck(type);
+    enqueuer.resolution.registerIsCheck(type);
+  }
 }
 
 class CompilerTask {
   final Compiler compiler;
   final Stopwatch watch;
 
   CompilerTask(this.compiler) : watch = new Stopwatch();
 
   String get name => 'Unknown task';
   int get timing => watch.elapsedInMs();
@@ skipping 50 matching lines @@
     final endOffset = end.charOffset + end.slowCharCount;
 
     // [begin] and [end] might be the same for the same empty token. This
     // happens for instance when scanning '$$'.
     assert(endOffset >= beginOffset);
     return f(beginOffset, endOffset);
   }
 
   String toString() => 'SourceSpan($uri, $begin, $end)';
 }