Enable TLS channeld id by default.

Enable TLS channeld id by default.

Replace --enable-origin-bound-certs command line flag with
--disable-tls-channel-id.

Remove field trial.

BUG=136462, 129174
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156939

[Ryan Hamilton, 2012-09-12 21:32:22]

http://codereview.chromium.org/10910240/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10910240/diff/1/chrome/common/chrome_switches....
chrome/common/chrome_switches.cc:413: const char kDisableTLSChannelID[]         
 = "disable-tls-channel-id";
I see that the old switch has been removed (good) but I don't see the new switch
being used.  Am I missing it?

[mattm, 2012-09-12 21:47:57]

http://codereview.chromium.org/10910240/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10910240/diff/1/chrome/common/chrome_switches....
chrome/common/chrome_switches.cc:413: const char kDisableTLSChannelID[]         
 = "disable-tls-channel-id";
On 2012/09/12 21:32:22, Ryan Hamilton wrote:
> I see that the old switch has been removed (good) but I don't see the new
switch
> being used.  Am I missing it?

It's done by the change in chrome/browser/prefs/command_line_pref_store.cc

[Ryan Hamilton, 2012-09-12 22:00:14]

lgtm

[mattm, 2012-09-14 18:36:13]

Updated.  Fixed the crashing if server_bound_cert_service_ was null.  ALso
updated a bunch of places that seemed like they should be creating a
ServerBoundCertService but weren't (I used the rule of thumb: if it's creating a
CookieMonster, it should also create a ServerBoundCertService).

[mattm, 2012-09-14 21:26:00]

On 2012/09/14 18:36:13, mattm wrote:
> Updated.  Fixed the crashing if server_bound_cert_service_ was null.  ALso
> updated a bunch of places that seemed like they should be creating a
> ServerBoundCertService but weren't (I used the rule of thumb: if it's creating
a
> CookieMonster, it should also create a ServerBoundCertService).

On second thought, I'll move the rest of those changes out to a different CL
(http://codereview.chromium.org/10909245/)

[commit-bot: I haz the power, 2012-09-14 21:31:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/10910240/8003

[commit-bot: I haz the power, 2012-09-14 21:31:32]

Presubmit check for 10910240-8003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/browser/prefs

Presubmit checks took 1.2s to calculate.

[mattm, 2012-09-14 21:34:29]

+brettw for chrome/ owners stamp

[brettw, 2012-09-14 22:12:20]

lgtm rubberstamp

[commit-bot: I haz the power, 2012-09-14 22:28:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/10910240/8003

[commit-bot: I haz the power, 2012-09-15 00:23:09]

Change committed as 156939