Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 10910164: Removes the grid from ash. (Closed)

Created:
8 years, 3 months ago by sky
Modified:
8 years, 3 months ago
CC:
chromium-reviews, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

Removes the grid from ash. BUG=137338 TEST=covered by tests. R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155779

Patch Set 1 #

Patch Set 2 : Remove todo #

Patch Set 3 : More removals #

Patch Set 4 : Fix ShelfBrowserTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -549 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/shell.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M ash/wm/base_layout_manager.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/wm/base_layout_manager.cc View 3 chunks +16 lines, -24 lines 0 comments Download
M ash/wm/base_layout_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/custom_frame_view_ash_unittest.cc View 7 chunks +5 lines, -7 lines 0 comments Download
M ash/wm/default_window_resizer.cc View 3 chunks +1 line, -25 lines 0 comments Download
M ash/wm/gestures/system_pinch_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/gestures/two_finger_drag_handler.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/wm/toplevel_window_event_filter.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ash/wm/toplevel_window_event_filter.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ash/wm/toplevel_window_event_filter_unittest.cc View 5 chunks +2 lines, -46 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M ash/wm/window_resizer.h View 3 chunks +5 lines, -20 lines 0 comments Download
M ash/wm/window_resizer.cc View 6 chunks +7 lines, -57 lines 0 comments Download
M ash/wm/workspace/base_workspace_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/snap_sizer.h View 2 chunks +1 line, -5 lines 0 comments Download
M ash/wm/workspace/snap_sizer.cc View 3 chunks +6 lines, -10 lines 0 comments Download
M ash/wm/workspace/workspace2.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace2.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace_event_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_filter_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager2.cc View 3 chunks +7 lines, -22 lines 0 comments Download
M ash/wm/workspace/workspace_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ash/wm/workspace/workspace_manager2.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/wm/workspace/workspace_manager2.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M ash/wm/workspace/workspace_manager2_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 3 chunks +13 lines, -12 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 18 chunks +26 lines, -59 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 31 chunks +36 lines, -89 lines 0 comments Download
M ash/wm/workspace_controller.h View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M ash/wm/workspace_controller.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/shelf_browsertest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/window_positioner.cc View 3 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/ui/ash/window_positioner_unittest.cc View 8 chunks +14 lines, -17 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 6 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sky
8 years, 3 months ago (2012-09-10 15:43:38 UTC) #1
Ben Goodger (Google)
lgtm On Mon, Sep 10, 2012 at 8:43 AM, <sky@chromium.org> wrote: > Reviewers: Ben Goodger ...
8 years, 3 months ago (2012-09-10 15:46:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10910164/46
8 years, 3 months ago (2012-09-10 15:47:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10910164/3002
8 years, 3 months ago (2012-09-10 15:59:54 UTC) #4
commit-bot: I haz the power
Try job failure for 10910164-3002 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-09-10 16:37:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10910164/4004
8 years, 3 months ago (2012-09-10 16:45:19 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 18:40:08 UTC) #7
Change committed as 155779

Powered by Google App Engine
This is Rietveld 408576698