Issue 10910064: Extension Commands: Add [Manage Shortcuts] link to the Extension Install Bubble (Views and GTK only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10910064: Extension Commands: Add [Manage Shortcuts] link to the Extension Install Bubble (Views and GTK only) (Closed)

Created:
8 years, 3 months ago by Finnur

Modified:
8 years, 3 months ago

Reviewers:
Elliot Glaysher, sky

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Extension Commands: Add [Manage Shortcuts] link to the Extension Install Bubble (Views and GTK only). BUG=145951 TEST=Install an extension with a keybinding (any extension with a browser action will do). Make sure the Manage Shortcut link appears and takes you to the chrome://extensions page with the config UI for commands open. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154927

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -4 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc	View	1	3 chunks	+22 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_installed_bubble.cc	View		10 chunks	+39 lines, -3 lines	0 comments	Download
M	chrome/common/url_constants.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Finnur

Elliot, can you take the first three files (grd and gtk). Scott, can you take ...

8 years, 3 months ago (2012-09-03 14:28:59 UTC) #1

gtk lgtm

Expand Messages | Collapse Messages