Rename PACKAGED_APP references to LEGACY_PACKAGED_APP

chrome/common/extensions/extension.h

Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 22ca9fb9e72f599c8d42e0856c963e19a6256461..974822d2957731846de73456b60b20ecebd19901 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -131,7 +131,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
     TYPE_THEME,
     TYPE_USER_SCRIPT,
     TYPE_HOSTED_APP,
-    TYPE_PACKAGED_APP,
+    TYPE_LEGACY_PACKAGED_APP,

[Nico, 2012/09/27 02:15:14]

What's the motivation behind this change? Do you want to introduce a new
TYPE_PACKAGED_APP enum for a new packaged app concept? In that case _V1 and _V2
might be better names (v2 might become legacy too eventually after all).

If it's to distinguish this from TYPE_PLATFORM_APP, maybe you can add a comment
to that end. ("// This is marked legacy because platform apps are preferred. For
backwards compatibility, we can't remove support for packaged apps") or
something like that.

     TYPE_PLATFORM_APP
   };
 
@@ -724,11 +724,11 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
 
   // App-related.
   bool is_app() const {
-    return is_packaged_app() || is_hosted_app() || is_platform_app();
+    return is_legacy_packaged_app() || is_hosted_app() || is_platform_app();
   }
   bool is_platform_app() const;
   bool is_hosted_app() const;
-  bool is_packaged_app() const;
+  bool is_legacy_packaged_app() const;
   bool is_storage_isolated() const { return is_storage_isolated_; }
   const URLPatternSet& web_extent() const { return extent_; }
   const std::string& launch_local_path() const { return launch_local_path_; }