Rename PACKAGED_APP references to LEGACY_PACKAGED_APP

chrome/common/extensions/extension.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 
 #include <algorithm>
 #include <iosfwd>
 #include <map>
@@ skipping 113 matching lines @@
   };
 
   // Do not change the order of entries or remove entries in this list
   // as this is used in UMA_HISTOGRAM_ENUMERATIONs about extensions.
   enum Type {
     TYPE_UNKNOWN = 0,
     TYPE_EXTENSION,
     TYPE_THEME,
     TYPE_USER_SCRIPT,
     TYPE_HOSTED_APP,
-    TYPE_PACKAGED_APP,
+    TYPE_LEGACY_PACKAGED_APP,

[Nico, 2012/09/27 02:15:14]

What's the motivation behind this change? Do you want to introduce a new
TYPE_PACKAGED_APP enum for a new packaged app concept? In that case _V1 and _V2
might be better names (v2 might become legacy too eventually after all).

If it's to distinguish this from TYPE_PLATFORM_APP, maybe you can add a comment
to that end. ("// This is marked legacy because platform apps are preferred. For
backwards compatibility, we can't remove support for packaged apps") or
something like that.

     TYPE_PLATFORM_APP
   };
 
   enum SyncType {
     SYNC_TYPE_NONE = 0,
     SYNC_TYPE_EXTENSION,
     SYNC_TYPE_APP
   };
 
   // Declared requirements for the extension.
@@ skipping 572 matching lines @@
   bool wants_file_access() const { return wants_file_access_; }
   int creation_flags() const { return creation_flags_; }
   bool from_webstore() const { return (creation_flags_ & FROM_WEBSTORE) != 0; }
   bool from_bookmark() const { return (creation_flags_ & FROM_BOOKMARK) != 0; }
   bool was_installed_by_default() const {
     return (creation_flags_ & WAS_INSTALLED_BY_DEFAULT) != 0;
   }
 
   // App-related.
   bool is_app() const {
-    return is_packaged_app() || is_hosted_app() || is_platform_app();
+    return is_legacy_packaged_app() || is_hosted_app() || is_platform_app();
   }
   bool is_platform_app() const;
   bool is_hosted_app() const;
-  bool is_packaged_app() const;
+  bool is_legacy_packaged_app() const;
   bool is_storage_isolated() const { return is_storage_isolated_; }
   const URLPatternSet& web_extent() const { return extent_; }
   const std::string& launch_local_path() const { return launch_local_path_; }
   const std::string& launch_web_url() const { return launch_web_url_; }
   extension_misc::LaunchContainer launch_container() const {
     return launch_container_;
   }
   int launch_width() const { return launch_width_; }
   int launch_height() const { return launch_height_; }
 
@@ skipping 489 matching lines @@
 
   UpdatedExtensionPermissionsInfo(
       const Extension* extension,
       const PermissionSet* permissions,
       Reason reason);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_H_