Redirect USER_DATA_DIR for GoogleUpdateTest and FirstRunTest.

Redirect USER_DATA_DIR for GoogleUpdateTest and FirstRunTest.
   
They used to write to the default user data dir, which breaks test isolation and is flaky due to leaking state.

BUG=chromium:146032
TEST=unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154618

[Mattias Nissler (ping if slow), 2012-08-31 20:41:55]

Please review.

[Lei Zhang, 2012-08-31 20:49:48]

LGTM with nit below

http://codereview.chromium.org/10909037/diff/1/chrome/browser/google/google_u...
File chrome/browser/google/google_update_settings_unittest.cc (right):

http://codereview.chromium.org/10909037/diff/1/chrome/browser/google/google_u...
chrome/browser/google/google_update_settings_unittest.cc:17: GoogleUpdateTest()
{}
needs a virtual destructor as well.

[Mattias Nissler (ping if slow), 2012-08-31 20:56:18]

http://codereview.chromium.org/10909037/diff/1/chrome/browser/google/google_u...
File chrome/browser/google/google_update_settings_unittest.cc (right):

http://codereview.chromium.org/10909037/diff/1/chrome/browser/google/google_u...
chrome/browser/google/google_update_settings_unittest.cc:17: GoogleUpdateTest()
{}
On 2012/08/31 20:49:48, Lei Zhang wrote:
> needs a virtual destructor as well.

Done.

[commit-bot: I haz the power, 2012-08-31 20:56:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/10909037/9001

[Mattias Nissler (ping if slow), 2012-08-31 21:57:04]

+jhawkins for FirstRunTest.

I don't understand why this wasn't a problem earlier? Was there a more central
redirect for USER_DATA_DIR that got removed recently? A few log checks didn't
turn up anything...

[James Hawkins, 2012-08-31 23:38:18]

lgtm

[commit-bot: I haz the power, 2012-09-01 11:15:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/10909037/12002

[commit-bot: I haz the power, 2012-09-01 16:17:13]

Change committed as 154618