Issue 10908285: Add WebContents accessor in ContentViewCore interface.

Issue 10908285: Add WebContents accessor in ContentViewCore interface. (Closed)

Created:
8 years, 3 months ago by nilesh

Modified:
8 years, 3 months ago

Reviewers:
Ted C, joth, jam, wrong_tedchoc

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add WebContents accessor in ContentViewCore interface. This fixes some compile errors while building Chrome for Adroid with upstream chromium. Also removed methods from the public interface which were not used from outside content. BUG=137571 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157605

Patch Set 1 #

Total comments: 3

Patch Set 2 : More cleanup #

Patch Set 3 : Fix build errors #

Patch Set 4 : Rename web_contents() to GetWebContents() #

Patch Set 5 : Rebase #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -41 lines)			Patch
M	content/browser/android/content_settings.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/android/content_view_core_impl.h	View	1 2 3 4	4 chunks	+8 lines, -9 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.cc	View	1 2 3 4	2 chunks	+8 lines, -4 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	1 2 3 4	3 chunks	+3 lines, -4 lines	0 comments	Download
M	content/public/browser/android/content_view_core.h	View	1 2 3 4	2 chunks	+6 lines, -23 lines	1 comment	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Ted C

http://codereview.chromium.org/10908285/diff/1/content/browser/android/content_view_core_impl.h File content/browser/android/content_view_core_impl.h (right): http://codereview.chromium.org/10908285/diff/1/content/browser/android/content_view_core_impl.h#newcode172 content/browser/android/content_view_core_impl.h:172: virtual WebContents* web_contents() const OVERRIDE; Hmm...I thought the hacker ...

8 years, 3 months ago (2012-09-17 18:19:44 UTC) #2

nilesh

Hi John, Please take a look at content/public/* I see both web_contents() and GetWebContents() being ...

8 years, 3 months ago (2012-09-17 21:08:29 UTC) #3

nilesh

PTAL. Cleaned up content_view_core.h to remove unused public methods.

8 years, 3 months ago (2012-09-18 18:21:12 UTC) #4

jam

8 years, 3 months ago (2012-09-18 19:15:21 UTC) #6

nilesh

PTAL. http://codereview.chromium.org/10908285/diff/1/content/browser/android/content_view_core_impl.h File content/browser/android/content_view_core_impl.h (right): http://codereview.chromium.org/10908285/diff/1/content/browser/android/content_view_core_impl.h#newcode172 content/browser/android/content_view_core_impl.h:172: virtual WebContents* web_contents() const OVERRIDE; Renamed to GetWebContents()

8 years, 3 months ago (2012-09-18 20:47:12 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10908285/12003

8 years, 3 months ago (2012-09-19 16:57:07 UTC) #9

joth

8 years, 3 months ago (2012-09-24 23:16:27 UTC) #10

lgtm

https://chromiumcodereview.appspot.com/10908285/diff/12003/content/public/bro...
File content/public/browser/android/content_view_core.h (left):

https://chromiumcodereview.appspot.com/10908285/diff/12003/content/public/bro...
content/public/browser/android/content_view_core.h:45: //
--------------------------------------------------------------------------
awesome, thanks for cleaning this up!

Expand Messages | Collapse Messages