Add WebContents accessor in ContentViewCore interface.

content/browser/android/content_view_core_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
 
 #include <vector>
 
 #include "base/android/jni_helper.h"
@@ skipping 151 matching lines @@
   // Called when page loading begins.
   void DidStartLoading();
   void StartContentIntent(const GURL& content_url);
 
   // --------------------------------------------------------------------------
   // Methods called from native code
   // --------------------------------------------------------------------------
 
   gfx::Rect GetBounds() const;
 
-  WebContents* web_contents() const { return web_contents_; }
-
+  virtual WebContents* web_contents() const OVERRIDE;

[Ted C, 2012/09/17 18:19:44]

Hmm...I thought the hacker style naming was only for simple inlined getters.  In
this case, does it need to become GetWebContents?

[jam, 2012/09/18 19:15:22]

correct, this should be GetWebContents()

web_contents() in content/public is on WebContentsObserver which isn't a virtual
method, but is a convenience getter. I see there's also one on
RenderViewHostTestHarness, but that's wrong and was supposed to be fixed but
wasn't yet.

[nilesh, 2012/09/18 20:47:12]

Renamed to GetWebContents()

   virtual void LoadUrl(NavigationController::LoadURLParams& params) OVERRIDE;
 
  private:
   // NotificationObserver implementation.
   virtual void Observe(int type,
                        const NotificationSource& source,
                        const NotificationDetails& details) OVERRIDE;
 
   // --------------------------------------------------------------------------
   // Private methods that call to Java via JNI
@@ skipping 33 matching lines @@
   bool tab_crashed_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
 };
 
 bool RegisterContentViewCore(JNIEnv* env);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_