net/test/python_utils.h - Issue 10907162: Reland: Take 2: Force python test server output to be unbuffered, so it doesn't mix with gtest outpu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/python_utils.h

Issue 10907162: Reland: Take 2: Force python test server output to be unbuffered, so it doesn't mix with gtest outpu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make GetPythonRunTime take a CommandLine instead of a FilePath. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/test/python_utils.h

diff --git a/net/test/python_utils.h b/net/test/python_utils.h

index 583fb2741a7353a4363933138639a74721fb5726..f1fcb4203ddee18feea7d918e98ddbe0c34f58d4 100644

--- a/net/test/python_utils.h

+++ b/net/test/python_utils.h

@@ -7,6 +7,7 @@

#include "base/compiler_specific.h"

+class CommandLine;

class FilePath;

// This is the python path variable name.

@@ -18,7 +19,7 @@ void AppendToPythonPath(const FilePath& dir);

// Return the location of the compiler-generated python protobuf.

bool GetPyProtoPath(FilePath* dir);

-// Returns the path that should be used to launch Python.

-bool GetPythonRunTime(FilePath* path) WARN_UNUSED_RESULT;

+// Returns the command that should be used to launch Python.

+bool GetPythonRunTime(CommandLine* python_cmd) WARN_UNUSED_RESULT;

Paweł Hajdan Jr. 2012/09/12 10:37:25 nit: Please also rename the function, GetPythonRun

Raghu Simha 2012/09/12 18:31:20 Done.

#endif // NET_TEST_PYTHON_UTILS_H_

« content/public/test/browser_test_utils.cc ('K') | « net/test/local_test_server_win.cc ('k') | net/test/python_utils.cc » ('j') | no next file with comments »