net/test/python_utils.h - Issue 10907162: Reland: Take 2: Force python test server output to be unbuffered, so it doesn't mix with gtest outpu

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/test/python_utils.h

Issue 10907162: Reland: Take 2: Force python test server output to be unbuffered, so it doesn't mix with gtest outpu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make GetPythonRunTime take a CommandLine instead of a FilePath. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_TEST_PYTHON_UTILS_H_	5 #ifndef NET_TEST_PYTHON_UTILS_H_

6 #define NET_TEST_PYTHON_UTILS_H_	6 #define NET_TEST_PYTHON_UTILS_H_

7	7

8 #include "base/compiler_specific.h"	8 #include "base/compiler_specific.h"

9	9

	10 class CommandLine;

10 class FilePath;	11 class FilePath;

11	12

12 // This is the python path variable name.	13 // This is the python path variable name.

13 extern const char kPythonPathEnv[];	14 extern const char kPythonPathEnv[];

14	15

15 // Appends the dir to python path environment variable.	16 // Appends the dir to python path environment variable.

16 void AppendToPythonPath(const FilePath& dir);	17 void AppendToPythonPath(const FilePath& dir);

17	18

18 // Return the location of the compiler-generated python protobuf.	19 // Return the location of the compiler-generated python protobuf.

19 bool GetPyProtoPath(FilePath* dir);	20 bool GetPyProtoPath(FilePath* dir);

20	21

21 // Returns the path that should be used to launch Python.	22 // Returns the command that should be used to launch Python.

22 bool GetPythonRunTime(FilePath* path) WARN_UNUSED_RESULT;	23 bool GetPythonRunTime(CommandLine* python_cmd) WARN_UNUSED_RESULT;
	Paweł Hajdan Jr. 2012/09/12 10:37:25 nit: Please also rename the function, GetPythonRun nit: Please also rename the function, GetPythonRunTime -> GetPythonCommand or GetPythonCommandLine (you had to change all call sites anyway). I'm fine with always using unbuffered output. Raghu Simha 2012/09/12 18:31:20 Done. Show quoted text On 2012/09/12 10:37:25, Paweł Hajdan Jr. wrote: > nit: Please also rename the function, GetPythonRunTime -> GetPythonCommand or > GetPythonCommandLine (you had to change all call sites anyway). > > I'm fine with always using unbuffered output. Done.
23	24

24 #endif // NET_TEST_PYTHON_UTILS_H_	25 #endif // NET_TEST_PYTHON_UTILS_H_

OLD	NEW

« content/public/test/browser_test_utils.cc ('K') | « net/test/local_test_server_win.cc ('k') | net/test/python_utils.cc » ('j') | no next file with comments »