Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: chrome/browser/extensions/api/context_menu/context_menu_api.cc

Issue 10907151: Extensions Docs Server: Enum values do not show up if enum is a type (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add back braces Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/context_menu/context_menu_api.cc
diff --git a/chrome/browser/extensions/api/context_menu/context_menu_api.cc b/chrome/browser/extensions/api/context_menu/context_menu_api.cc
index a87a3491ec37919f936efeaf2b67368fb56ab5ec..6849304650772935099528c4e33a29dd311dcc32 100644
--- a/chrome/browser/extensions/api/context_menu/context_menu_api.cc
+++ b/chrome/browser/extensions/api/context_menu/context_menu_api.cc
@@ -75,6 +75,8 @@ extensions::MenuItem::ContextList GetContexts(
case PropertyWithEnumT::CONTEXTS_ELEMENT_FRAME:
contexts.Add(extensions::MenuItem::FRAME);
break;
+ default:
+ NOTREACHED();
not at google - send to devlin 2012/09/14 01:44:51 the problem is the presence of a NONE case right?
cduvall 2012/09/17 22:07:46 Done.
}
}
return contexts;
@@ -243,6 +245,8 @@ bool UpdateContextMenuFunction::RunImpl() {
case Update::Params::ID_INTEGER:
item_id.uid = *params->id_integer;
break;
+ default:
+ NOTREACHED();
not at google - send to devlin 2012/09/14 01:44:51 ditto
cduvall 2012/09/17 22:07:46 Done.
}
ExtensionService* service = profile()->GetExtensionService();
@@ -344,6 +348,9 @@ bool RemoveContextMenuFunction::RunImpl() {
break;
case Remove::Params::MENU_ITEM_ID_INTEGER:
id.uid = *params->menu_item_id_integer;
+ break;
+ default:
+ NOTREACHED();
not at google - send to devlin 2012/09/14 01:44:51 ditto
cduvall 2012/09/17 22:07:46 Done.
}
MenuItem* item = manager->GetItemById(id);

Powered by Google App Engine
This is Rietveld 408576698