Chromium Code Reviews| Index: chrome/browser/extensions/api/context_menu/context_menu_api.cc |
| diff --git a/chrome/browser/extensions/api/context_menu/context_menu_api.cc b/chrome/browser/extensions/api/context_menu/context_menu_api.cc |
| index a87a3491ec37919f936efeaf2b67368fb56ab5ec..6849304650772935099528c4e33a29dd311dcc32 100644 |
| --- a/chrome/browser/extensions/api/context_menu/context_menu_api.cc |
| +++ b/chrome/browser/extensions/api/context_menu/context_menu_api.cc |
| @@ -75,6 +75,8 @@ extensions::MenuItem::ContextList GetContexts( |
| case PropertyWithEnumT::CONTEXTS_ELEMENT_FRAME: |
| contexts.Add(extensions::MenuItem::FRAME); |
| break; |
| + default: |
| + NOTREACHED(); |
|
not at google - send to devlin
2012/09/14 01:44:51
the problem is the presence of a NONE case right?
cduvall
2012/09/17 22:07:46
Done.
|
| } |
| } |
| return contexts; |
| @@ -243,6 +245,8 @@ bool UpdateContextMenuFunction::RunImpl() { |
| case Update::Params::ID_INTEGER: |
| item_id.uid = *params->id_integer; |
| break; |
| + default: |
| + NOTREACHED(); |
|
not at google - send to devlin
2012/09/14 01:44:51
ditto
cduvall
2012/09/17 22:07:46
Done.
|
| } |
| ExtensionService* service = profile()->GetExtensionService(); |
| @@ -344,6 +348,9 @@ bool RemoveContextMenuFunction::RunImpl() { |
| break; |
| case Remove::Params::MENU_ITEM_ID_INTEGER: |
| id.uid = *params->menu_item_id_integer; |
| + break; |
| + default: |
| + NOTREACHED(); |
|
not at google - send to devlin
2012/09/14 01:44:51
ditto
cduvall
2012/09/17 22:07:46
Done.
|
| } |
| MenuItem* item = manager->GetItemById(id); |