Extensions Docs Server: Enum values do not show up if enum is a type

chrome/browser/extensions/api/context_menu/context_menu_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/context_menu/context_menu_api.h"
 
 #include <string>
 
 #include "base/values.h"
 #include "base/string_number_conversions.h"
@@ skipping 57 matching lines @@
         break;
       case PropertyWithEnumT::CONTEXTS_ELEMENT_VIDEO:
         contexts.Add(extensions::MenuItem::VIDEO);
         break;
       case PropertyWithEnumT::CONTEXTS_ELEMENT_AUDIO:
         contexts.Add(extensions::MenuItem::AUDIO);
         break;
       case PropertyWithEnumT::CONTEXTS_ELEMENT_FRAME:
         contexts.Add(extensions::MenuItem::FRAME);
         break;
+      default:
+        NOTREACHED();

[not at google - send to devlin, 2012/09/14 01:44:51]

the problem is the presence of a NONE case right? can you just deal with that
explicitly?

[cduvall, 2012/09/17 22:07:46]

Done.

     }
   }
   return contexts;
 }
 
 template<typename PropertyWithEnumT>
 extensions::MenuItem::Type GetType(const PropertyWithEnumT& property) {
   switch (property.type) {
     case PropertyWithEnumT::TYPE_NONE:
     case PropertyWithEnumT::TYPE_NORMAL:
@@ skipping 148 matching lines @@
   scoped_ptr<Update::Params> params(Update::Params::Create(*args_));
 
   EXTENSION_FUNCTION_VALIDATE(params.get());
   switch (params->id_type) {
     case Update::Params::ID_STRING:
       item_id.string_uid = *params->id_string;
       break;
     case Update::Params::ID_INTEGER:
       item_id.uid = *params->id_integer;
       break;
+    default:
+      NOTREACHED();

[not at google - send to devlin, 2012/09/14 01:44:51]

ditto

[cduvall, 2012/09/17 22:07:46]

Done.

   }
 
   ExtensionService* service = profile()->GetExtensionService();
   MenuManager* manager = service->menu_manager();
   MenuItem* item = manager->GetItemById(item_id);
   if (!item || item->extension_id() != extension_id()) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(
         kCannotFindItemError, GetIDString(item_id));
     return false;
   }
@@ skipping 81 matching lines @@
   ExtensionService* service = profile()->GetExtensionService();
   MenuManager* manager = service->menu_manager();
 
   MenuItem::Id id(profile()->IsOffTheRecord(), extension_id());
   switch (params->menu_item_id_type) {
     case Remove::Params::MENU_ITEM_ID_STRING:
       id.string_uid = *params->menu_item_id_string;
       break;
     case Remove::Params::MENU_ITEM_ID_INTEGER:
       id.uid = *params->menu_item_id_integer;
+      break;
+    default:
+      NOTREACHED();

[not at google - send to devlin, 2012/09/14 01:44:51]

ditto

[cduvall, 2012/09/17 22:07:46]

Done.

   }
 
   MenuItem* item = manager->GetItemById(id);
   // Ensure one extension can't remove another's menu items.
   if (!item || item->extension_id() != extension_id()) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(
         kCannotFindItemError, GetIDString(id));
     return false;
   }
 
   if (!manager->RemoveContextMenuItem(id))
     return false;
   manager->WriteToStorage(GetExtension());
   return true;
 }
 
 bool RemoveAllContextMenusFunction::RunImpl() {
   ExtensionService* service = profile()->GetExtensionService();
   MenuManager* manager = service->menu_manager();
   manager->RemoveAllContextItems(GetExtension()->id());
   manager->WriteToStorage(GetExtension());
   return true;
 }
 
 }  // namespace extensions