Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7699)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 10905296: Adjusted action box menu position relative to omnibox and action box menu button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index aba7b08857ada9090683767ae52d9740ebe016f3..40311e634c4822420414babaa4b65c02311eca99 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -311,8 +311,12 @@ void LocationBarView::Init(views::View* popup_parent_view) {
star_view_->SetVisible(true);
}
if (extensions::switch_utils::IsActionBoxEnabled() && browser_) {
- action_box_button_view_ = new ActionBoxButtonView(browser_);
+ gfx::Point menu_offset(
Peter Kasting 2012/09/14 22:50:53 Nit: I would probably inline this into the next st
yefimt 2012/09/14 23:00:56 I always felt that N one line expressions are more
+ (mode_ == NORMAL) ? kNormalHorizontalEdgeThickness : 0,
+ kVerticalEdgeThickness);
+ action_box_button_view_ = new ActionBoxButtonView(browser_, menu_offset);
AddChildView(action_box_button_view_);
+
if (star_view_)
star_view_->SetVisible(false);
}

Powered by Google App Engine
This is Rietveld 408576698