chrome/browser/ui/views/location_bar/action_box_button_view.h - Issue 10905296: Adjusted action box menu position relative to omnibox and action box menu button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/action_box_button_view.h

Issue 10905296: Adjusted action box menu position relative to omnibox and action box menu button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/action_box_menu.cc ('K') | « chrome/browser/ui/views/action_box_menu.cc ('k') | chrome/browser/ui/views/location_bar/action_box_button_view.cc » ('j') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/action_box_button_view.h

diff --git a/chrome/browser/ui/views/location_bar/action_box_button_view.h b/chrome/browser/ui/views/location_bar/action_box_button_view.h

index 1111952d30c90a77ce4fd88ff066c75aa9166591..165ae9ffe2e46d8aa00ff4c383394a9bb18d08f7 100644

--- a/chrome/browser/ui/views/location_bar/action_box_button_view.h

+++ b/chrome/browser/ui/views/location_bar/action_box_button_view.h

@@ -14,7 +14,7 @@ class Browser;

class ActionBoxButtonView : public views::MenuButton,

public views::MenuButtonListener {

public:

- explicit ActionBoxButtonView(Browser* browser);

+ explicit ActionBoxButtonView(Browser* browser, gfx::Point menu_offset);

Peter Kasting 2012/09/14 22:50:53 Nit: Pass by const ref

yefimt 2012/09/14 23:00:56 Done.

virtual ~ActionBoxButtonView();

SkColor GetBackgroundColor();

@@ -30,6 +30,8 @@ class ActionBoxButtonView : public views::MenuButton,

Browser* browser_;

+ gfx::Point menu_offset_;

DISALLOW_COPY_AND_ASSIGN(ActionBoxButtonView);

};