chrome/browser/ui/views/action_box_menu.cc - Issue 10905296: Adjusted action box menu position relative to omnibox and action box menu button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/action_box_menu.cc

Issue 10905296: Adjusted action box menu position relative to omnibox and action box menu button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/action_box_menu.h ('k') | chrome/browser/ui/views/location_bar/action_box_button_view.h » ('j') | chrome/browser/ui/views/location_bar/action_box_button_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/action_box_menu.cc

diff --git a/chrome/browser/ui/views/action_box_menu.cc b/chrome/browser/ui/views/action_box_menu.cc

index 4412d03c87188462196e16303dceef1251d5d93b..bde9e8c1746186fb760608b24947a440e306af8c 100644

--- a/chrome/browser/ui/views/action_box_menu.cc

+++ b/chrome/browser/ui/views/action_box_menu.cc

@@ -40,8 +40,9 @@ void ActionBoxMenu::Init() {

PopulateMenu();

}

-void ActionBoxMenu::RunMenu(views::MenuButton* menu_button) {

- gfx::Point screen_location;

+void ActionBoxMenu::RunMenu(views::MenuButton* menu_button,

+ gfx::Point menu_offset) {

+ gfx::Point screen_location(menu_offset);

Peter Kasting 2012/09/14 22:50:53 Nit: Omit this line, you're passing by value preci

yefimt 2012/09/14 23:00:56 Done.

views::View::ConvertPointToScreen(menu_button, &screen_location);

menu_runner_.reset(new views::MenuRunner(root_));

// Ignore the result since we don't need to handle a deleted menu specially.