Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10905223: Converted policy_prefs_ui.py pyauto test to a browser_test. (Closed)

Created:
8 years, 3 months ago by Joao da Silva
Modified:
8 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Converted policy_prefs_ui.py pyauto test to a browser_test. BUG=143637 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156629

Patch Set 1 #

Patch Set 2 : Rebased, converted chrome/app/policy/PRESUBMIT.py #

Total comments: 2

Patch Set 3 : Removed GetPolicyDefinitionList automation call #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -756 lines) Patch
M chrome/app/policy/PRESUBMIT.py View 1 4 chunks +16 lines, -21 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 chunks +0 lines, -42 lines 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 1 5 chunks +93 lines, -1 line 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 31 chunks +162 lines, -160 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 5 chunks +0 lines, -11 lines 0 comments Download
D chrome/test/functional/policy_prefs_ui.py View 1 chunk +0 lines, -180 lines 0 comments Download
D chrome/test/functional/policy_test_cases.py View 1 chunk +0 lines, -312 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Joao da Silva
8 years, 3 months ago (2012-09-12 16:10:32 UTC) #1
jam
can you also double check that there are no more automation methods that got added ...
8 years, 3 months ago (2012-09-13 01:19:08 UTC) #2
Joao da Silva
The remaining policy-related automation code is still used: - SetUserPolicy/SetDevicePolicy aren't automation calls, and are ...
8 years, 3 months ago (2012-09-13 09:32:22 UTC) #3
jam
lgtm
8 years, 3 months ago (2012-09-13 17:04:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10905223/7004
8 years, 3 months ago (2012-09-13 17:19:27 UTC) #5
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
8 years, 3 months ago (2012-09-13 17:19:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10905223/13005
8 years, 3 months ago (2012-09-13 18:16:56 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 21:13:57 UTC) #8
Change committed as 156629

Powered by Google App Engine
This is Rietveld 408576698