Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 109043: Move l10n_util to app/ (Closed)

Created:
11 years, 7 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -1997 lines) Patch
M app/DEPS View 1 chunk +12 lines, -3 lines 0 comments Download
M app/app.vcproj View 1 chunk +16 lines, -0 lines 0 comments Download
A + app/l10n_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + app/l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + app/l10n_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
A + app/l10n_util_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A + app/l10n_util_win.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + app/l10n_util_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
app/resource_bundle_linux.cc View 2 chunks +1 line, -1 line 0 comments Download
M app/resource_bundle_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/alternate_nav_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/app_modal_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/app_modal_dialog_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
chrome/browser/back_forward_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_folder_tree_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_menu_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser_init.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser_main.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser_main_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser_uitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/character_encoding.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/find_bar_cocoa_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/sad_tab_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/tab_strip_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/debugger/debugger_window.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/downloads_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/history_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/download_item_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/download_request_dialog_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_shelf.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/save_package.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/drag_utils.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/encoding_menu_controller_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/gtk/about_chrome_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_editor_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/gtk/dialogs_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/download_shelf_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/gtk/find_bar_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/gtk/go_button_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/menu_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/standard_menus.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/tabs/tab_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/tabs/tab_renderer_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/tabs/tab_strip_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/hang_monitor/hung_plugin_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/history/query_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/url_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox2_importer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox3_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/ie_importer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/importer/toolbar_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/input_window_dialog_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jsmessage_box_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/login_prompt.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profile_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/session_history_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_error_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_policy.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/task_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/task_manager_resource_providers.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/toolbar_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/user_data_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/about_chrome_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc View 2 chunks +1 line, -1 line 0 comments Download
chrome/browser/views/blocked_popup_container.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bubble_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_editor_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/bug_report_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/clear_browsing_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/constrained_window_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/constrained_window_impl_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/download_item_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/download_shelf_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/edit_keyword_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/external_protocol_dialog.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/find_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_bubble.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_customize_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_view_base.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/opaque_browser_frame_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/fullscreen_exit_bubble.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/go_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/importer_lock_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/importer_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/importing_progress_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/infobars/infobars.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/jsmessage_box_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/keyword_editor_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/location_bar_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/login_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/new_profile_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/advanced_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/cookies_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/exceptions_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/fonts_languages_window_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/fonts_page_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/general_page_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/language_combobox_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/languages_page_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/options_group_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/options_window_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/passwords_exceptions_window_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/passwords_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/page_info_window.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/repost_form_warning_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/restart_message_box.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/sad_tab_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/select_profile_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/shelf_item_dialog.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/shell_dialogs_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/status_bubble_views.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/tabs/tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_renderer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 2 chunks +1 line, -1 line 0 comments Download
chrome/browser/views/toolbar_view.cc View 2 chunks +1 line, -1 line 0 comments Download
chrome/browser/views/uninstall_dialog.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/views/user_data_dir_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/child_process_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/common.vcproj View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/common/common_glue.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/gfx/chrome_canvas.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/gfx/chrome_canvas_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/gfx/chrome_font_win.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/l10n_util.h View 1 chunk +0 lines, -370 lines 0 comments Download
D chrome/common/l10n_util.cc View 1 chunk +0 lines, -745 lines 0 comments Download
D chrome/common/l10n_util_posix.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/common/l10n_util_unittest.cc View 1 chunk +0 lines, -435 lines 0 comments Download
D chrome/common/l10n_util_win.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/common/l10n_util_win.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M chrome/common/os_exchange_data.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/platform_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/security_filter_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/time_format.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/time_format_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/win_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/localized_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_main.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/accessibility/accessibility_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/accessibility/accessibility_util.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/test/unit/unittests.vcproj View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/views/accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/button/button_dropdown.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/button/menu_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/button/native_button.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/views/controls/button/text_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/combo_box.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/label.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/views/controls/label_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/menu/chrome_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/views/controls/menu/menu.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/views/controls/message_box_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/native_control.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/native_control_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/scrollbar/bitmap_scroll_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/views/controls/tabbed_pane.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/table/table_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/table/table_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/controls/text_field.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/views/controls/tree/tree_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/views/view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/widget/aero_tooltip_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/views/widget/tooltip_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/views/window/dialog_client_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/window/window_win.cc View 2 chunks +1 line, -1 line 0 comments Download
webkit/default_plugin/plugin_impl_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
11 years, 7 months ago (2009-05-05 20:48:26 UTC) #1
sky
11 years, 7 months ago (2009-05-05 20:55:31 UTC) #2
Rubber stamp LGTM.

Powered by Google App Engine
This is Rietveld 408576698