Issue 109012: Some cleanup of the mark-sweep/compact collector following the symbol...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109012: Some cleanup of the mark-sweep/compact collector following the symbol... (Closed)

Created:
11 years, 7 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Some cleanup of the mark-sweep/compact collector following the symbol table debacle. Committed: http://code.google.com/p/v8/source/detail?r=1856

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -33 lines)			Patch
M	src/global-handles.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/global-handles.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.h	View	3 chunks	+3 lines, -7 lines	2 comments	Download
M	src/mark-compact.cc	View	3 chunks	+21 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/109012/diff/1/2 File src/mark-compact.h (right): http://codereview.chromium.org/109012/diff/1/2#newcode205 Line 205: // Callback function for telling whether the ...

11 years, 7 months ago (2009-05-05 09:23:14 UTC) #2

Kevin Millikin (Chromium)

11 years, 7 months ago (2009-05-05 09:29:53 UTC) #3

http://codereview.chromium.org/109012/diff/1/2
File src/mark-compact.h (right):

http://codereview.chromium.org/109012/diff/1/2#newcode205
Line 205: // Callback function for telling whether the object *p must be marked.
On 2009/05/05 09:23:14, Kasper Lund wrote:
> Update comment?

Thanks, done.

Expand Messages | Collapse Messages