Enable run_remote_tests to run in chroot and clean up output

Enable run_remote_tests to run in chroot and clean up output

Make this script's output better formatted.  Better describe how
to disambiguate control files when multiple match.  Get rid of
the output_file concept since it's not needed.  Don't output
a results directory if there's an ambiguity.

[kmixter1, 2010-03-20 02:22:53]

Some spring cleaning and improving functionality for the fixit.

[petkov, 2010-03-20 04:25:26]

LGTM

You may want to consider adding some colors to the progress output -- portage is
quite colorful :-)

http://codereview.chromium.org/1090005/diff/4001/5001
File src/scripts/run_remote_tests.sh (right):

http://codereview.chromium.org/1090005/diff/4001/5001#newcode178
src/scripts/run_remote_tests.sh:178: local type=$(egrep '^\s*TEST_TYPE.*='
"${control_file}" | head -1)
Any reason for changing \s to .?

http://codereview.chromium.org/1090005/diff/4001/5001#newcode184
src/scripts/run_remote_tests.sh:184: option="-s"
indent by 1

[seano, 2010-03-20 21:34:52]

lgtm++

http://codereview.chromium.org/1090005/diff/4001/5001
File src/scripts/run_remote_tests.sh (right):

http://codereview.chromium.org/1090005/diff/4001/5001#newcode178
src/scripts/run_remote_tests.sh:178: local type=$(egrep '^\s*TEST_TYPE.*='
"${control_file}" | head -1)
On 2010/03/20 04:25:26, petkov wrote:
> Any reason for changing \s to .?

Looks like some of the control files are written as TEST_TYPE=

[kmixter1, 2010-03-22 22:14:27]

Submitting.  Added colors when stdout is not redirected from a tty.

http://codereview.chromium.org/1090005/diff/4001/5001
File src/scripts/run_remote_tests.sh (right):

http://codereview.chromium.org/1090005/diff/4001/5001#newcode178
src/scripts/run_remote_tests.sh:178: local type=$(egrep '^\s*TEST_TYPE.*='
"${control_file}" | head -1)
On 2010/03/20 21:34:52, seano wrote:
> On 2010/03/20 04:25:26, petkov wrote:
> > Any reason for changing \s to .?
> 
> Looks like some of the control files are written as TEST_TYPE=

Seems either like a bug or exclusion in the egrep that's emerged in the chroot. 
It doesn't support \s.  Changed to use [[:space:]].

http://codereview.chromium.org/1090005/diff/4001/5001#newcode184
src/scripts/run_remote_tests.sh:184: option="-s"
On 2010/03/20 04:25:26, petkov wrote:
> indent by 1

Done.

[petkov, 2010-03-22 22:25:52]

Sounds good. You may want to announce on the cros-dev mailing list that
run_remote_tests works inside chroot now...

On Mon, Mar 22, 2010 at 3:14 PM, <kmixter@chromium.org> wrote:

> Submitting.  Added colors when stdout is not redirected from a tty.
>
>
> http://codereview.chromium.org/1090005/diff/4001/5001
> File src/scripts/run_remote_tests.sh (right):
>
> http://codereview.chromium.org/1090005/diff/4001/5001#newcode178
> src/scripts/run_remote_tests.sh:178: local type=$(egrep
> '^\s*TEST_TYPE.*=' "${control_file}" | head -1)
> On 2010/03/20 21:34:52, seano wrote:
>
>> On 2010/03/20 04:25:26, petkov wrote:
>> > Any reason for changing \s to .?
>>
>
>  Looks like some of the control files are written as TEST_TYPE=
>>
>
> Seems either like a bug or exclusion in the egrep that's emerged in the
> chroot.  It doesn't support \s.  Changed to use [[:space:]].
>
> http://codereview.chromium.org/1090005/diff/4001/5001#newcode184
> src/scripts/run_remote_tests.sh:184: option="-s"
> On 2010/03/20 04:25:26, petkov wrote:
>
>> indent by 1
>>
>
> Done.
>
> http://codereview.chromium.org/1090005
>