Issue 1090002: Send session history offset and length parameters in the Navigate message to...

Issue 1090002: Send session history offset and length parameters in the Navigate message to... (Closed)

Created:
10 years, 9 months ago by darin (slow to review)

Modified:
10 years, 9 months ago

Reviewers:
brettw

CC:
chromium-reviews, jam+cc_chromium.org, brettw+cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Send session history offset and length parameters in the Navigate message to keep the renderer's notion of those values properly synchronized with the NavigationController. R=brettw BUG=18062 TEST=see session_history_uitest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42022

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -85 lines)			Patch
M	chrome/browser/renderer_host/render_view_host.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		2 chunks	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/session_history_uitest.cc	View	2	2 chunks	+37 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/navigation_controller.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/navigation_controller.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View		4 chunks	+11 lines, -14 lines	0 comments	Download
M	chrome/common/chrome_constants.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_constants.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages.h	View		3 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/renderer/navigation_state.h	View		5 chunks	+15 lines, -3 lines	0 comments	Download
M	chrome/renderer/render_view.h	View		3 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2	10 chunks	+27 lines, -35 lines	1 comment	Download
A	chrome/test/data/session_history/record_length.html	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/1090002/diff/9002/14012 File chrome/renderer/render_view.cc (right): http://codereview.chromium.org/1090002/diff/9002/14012#newcode2563 chrome/renderer/render_view.cc:2563: history_list_length_ -= delta; This is a fancy way of ...

10 years, 9 months ago (2010-03-18 16:52:16 UTC) #2

darin (slow to review)

10 years, 9 months ago (2010-03-18 17:27:00 UTC) #3

brettw

10 years, 9 months ago (2010-03-18 18:21:17 UTC) #5

LGTM

http://codereview.chromium.org/1090002/diff/14017/25012
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/1090002/diff/14017/25012#newcode2559
chrome/renderer/render_view.cc:2559: history_list_offset_++;
Optional: did you consider writing this as:
  history_list_offset_++;
  if (history_list_offset >= chrome::kMaxSessionHistoryEntries)
    history_list_offset = chrome::kMaxSessionHistoryEntries - 1;
  history_list_length_ = history_list_offset + 1;

Expand Messages | Collapse Messages