Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1944)

Unified Diff: chrome/renderer/navigation_state.h

Issue 1090002: Send session history offset and length parameters in the Navigate message to... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/navigation_state.h
===================================================================
--- chrome/renderer/navigation_state.h (revision 41858)
+++ chrome/renderer/navigation_state.h (working copy)
@@ -33,15 +33,18 @@
static NavigationState* CreateBrowserInitiated(
int32 pending_page_id,
+ int pending_history_list_offset,
PageTransition::Type transition_type,
base::Time request_time) {
return new NavigationState(transition_type, request_time, false,
- pending_page_id);
+ pending_page_id,
+ pending_history_list_offset);
}
static NavigationState* CreateContentInitiated() {
// We assume navigations initiated by content are link clicks.
- return new NavigationState(PageTransition::LINK, base::Time(), true, -1);
+ return new NavigationState(PageTransition::LINK, base::Time(), true, -1,
+ -1);
}
static NavigationState* FromDataSource(WebKit::WebDataSource* ds) {
@@ -58,6 +61,12 @@
// Contains the page_id for this navigation or -1 if there is none yet.
int32 pending_page_id() const { return pending_page_id_; }
+ // If pending_page_id() is not -1, then this contains the corresponding
+ // offset of the page in the back/forward history list.
+ int pending_history_list_offset() const {
+ return pending_history_list_offset_;
+ }
+
// Contains the transition type that the browser specified when it
// initiated the load.
PageTransition::Type transition_type() const { return transition_type_; }
@@ -219,7 +228,8 @@
NavigationState(PageTransition::Type transition_type,
const base::Time& request_time,
bool is_content_initiated,
- int32 pending_page_id)
+ int32 pending_page_id,
+ int pending_history_list_offset)
: transition_type_(transition_type),
load_type_(UNDEFINED_LOAD),
request_time_(request_time),
@@ -227,6 +237,7 @@
request_committed_(false),
is_content_initiated_(is_content_initiated),
pending_page_id_(pending_page_id),
+ pending_history_list_offset_(pending_history_list_offset),
postpone_loading_data_(false),
cache_policy_override_set_(false),
cache_policy_override_(WebKit::WebURLRequest::UseProtocolCachePolicy),
@@ -248,6 +259,7 @@
bool request_committed_;
bool is_content_initiated_;
int32 pending_page_id_;
+ int pending_history_list_offset_;
GURL searchable_form_url_;
std::string searchable_form_encoding_;
scoped_ptr<webkit_glue::PasswordForm> password_form_data_;

Powered by Google App Engine
This is Rietveld 408576698