Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 10895: Add Terminate() to the Process object, have RenderProcessHost use this to avo... (Closed)

Created:
12 years, 1 month ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add Terminate() to the Process object, have RenderProcessHost use this to avoid some more Windows specific code. Move Process and SharedMemory into the base namespace (most changes). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -355 lines) Patch
M base/clipboard.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/clipboard_win.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M base/gfx/platform_canvas_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/multiprocess_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
M base/process.h View 5 chunks +14 lines, -13 lines 0 comments Download
M base/process_posix.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M base/process_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/process_util_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/process_util_unittest.cc View 6 chunks +12 lines, -11 lines 0 comments Download
M base/process_util_win.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/process_win.cc View 4 chunks +20 lines, -4 lines 0 comments Download
M base/run_all_perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/shared_memory.h View 4 chunks +5 lines, -2 lines 0 comments Download
M base/shared_memory_posix.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M base/shared_memory_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M base/shared_memory_win.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M base/stats_table.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M base/stats_table_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M base/trace_event.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/app/result_codes.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/browser.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_init.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/browser_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/greasemonkey_master.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/greasemonkey_master.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/greasemonkey_master_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/memory_details.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/memory_details.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/plugin_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_process_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/render_process_host.h View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/render_process_host.cc View 8 chunks +18 lines, -22 lines 0 comments Download
M chrome/browser/resource_dispatcher_host.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/resource_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resource_message_filter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/task_manager.h View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/task_manager.cc View 10 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/task_manager_resource_providers.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/visitedlink_master.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/visitedlink_master.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/visitedlink_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_process_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/ipc_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/plugin_messages_internal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/process_watcher.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/common/process_watcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/render_messages.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/render_messages_internal.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/resource_dispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/resource_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/plugin/webplugin_proxy.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/greasemonkey_slave.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/greasemonkey_slave.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/greasemonkey_slave_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/render_process.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/render_process.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/renderer/render_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/renderer/render_view.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_widget.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/render_widget.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/visitedlink_slave.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/visitedlink_slave.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/memory_test/memory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/chrome_mini_installer.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/perf/mem_usage.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ui_test.cc View 4 chunks +11 lines, -12 lines 0 comments Download
M chrome/tools/convert_dict/convert_dict.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/perf/flush_cache/flush_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/profiles/generate_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/test/image_diff/image_diff.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.h View 5 chunks +6 lines, -6 lines 0 comments Download
M webkit/glue/resource_handle_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/scoped_clipboard_writer_glue.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/run_all_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
I decided to add process and shared memory into the base namespace. After a while ...
12 years, 1 month ago (2008-11-13 21:05:28 UTC) #1
huanr
12 years, 1 month ago (2008-11-13 22:19:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698